set chmod flag by default on Windows

[jbuiss0n]

In response to this issue

[jedrichards]

Aha, that looks great, thanks.

Do you think its worth putting a check in there to see if there's already a --chmod=XXX arg in the array, and only using this default if there isn't? That way we won't change behaviour for someone using Windows and setting chmod to their own preference?

[jbuiss0n]

Yes you're totally right !

I was going to write a unit test to validate this feature, but a bdd test looks not very relevant, and a true unit test was going to import to many dependencies, don't you think?

Thanks for your availability !

[jedrichards]

In some of the tests we're passing through the noExec flag to stop rsync actually executing, and then asserting that the resulting command string is what we expect it to be. If you wanted to write a test for this you could do something similar?

https://github.com/jedrichards/rsyncwrapper/blob/master/tests/remote-src.js

[jbuiss0n]

Ho yes, it seems good, i'm on it.

Edit: I'll not be able to end it now, i hope to have time during this WE :)

[jbuiss0n]

It should now be alright.
Thanks a lot for your help !

[jedrichards]

Perfect, will check and merge soon (heading home for Christmas right now) ...