Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: regression with env overriding #4421

Merged
merged 1 commit into from
Feb 16, 2025
Merged

fix: regression with env overriding #4421

merged 1 commit into from
Feb 16, 2025

Conversation

jdx
Copy link
Owner

@jdx jdx commented Feb 16, 2025

regression caused by #4412

@jdx jdx enabled auto-merge (squash) February 16, 2025 19:52
@jdx jdx merged commit f057457 into main Feb 16, 2025
18 checks passed
@jdx jdx deleted the env-regression branch February 16, 2025 20:03
jdx pushed a commit that referenced this pull request Feb 16, 2025
### 🚀 Features

- add devcontainer generator by [@acesyde](https://github.com/acesyde)
in [#4355](#4355)
- added hk by [@jdx](https://github.com/jdx) in
[#4422](#4422)

### 🐛 Bug Fixes

- short flag with value and var=#true bug by
[@jdx](https://github.com/jdx) in
[#4419](#4419)
- regression with env overriding by [@jdx](https://github.com/jdx) in
[#4421](#4421)

### 📚 Documentation

- **(shims)** clarify `activate` only removes shims from `PATH` by
[@risu729](https://github.com/risu729) in
[#4418](#4418)
- Update shims page by [@hverlin](https://github.com/hverlin) in
[#4414](#4414)
@gawbul
Copy link

gawbul commented Feb 16, 2025

Ah, it looks like you have noticed this already 😂
I've been trying to debug all afternoon in #4420 😣
I narrowed it down to the same change you made in src/config/mod.rs, but don't know Rust well enough (at all), and would never have picked up the other changes you made.
Good I don't need to raise a PR now 👍
Thank you 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants