Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shim): Windows shim add hardlink & symlink mode #4409

Merged
merged 5 commits into from
Feb 25, 2025

Conversation

qianlongzt
Copy link
Contributor

@qianlongzt qianlongzt commented Feb 15, 2025

#4360

add setting windows_shim_mode

  1. file default, current implement
  2. hardlink, require on same filesystem
  3. symlink: Requires Windows Vista or later with admin privileges or enabling "Developer Mode" in Windows 10/11.

I am not familiar with Rust or the code base here

test on windows 11 24h2 with "Devloper Mode"

@jdx
Copy link
Owner

jdx commented Feb 24, 2025

could we get some e2e tests?

@qianlongzt
Copy link
Contributor Author

could we get some e2e tests?

I added test

@jdx jdx merged commit e9bd775 into jdx:main Feb 25, 2025
18 checks passed
@qianlongzt qianlongzt deleted the feat-windows-shim branch February 25, 2025 00:44
jdx pushed a commit that referenced this pull request Feb 25, 2025
### 🚀 Features

- **(registry)** add checkmake to registry by
[@eread](https://github.com/eread) in
[#4466](#4466)
- **(registry)** added sops from aqua registry by
[@ldrouard](https://github.com/ldrouard) in
[#4457](#4457)
- **(registry)** added k9s from aqua registry by
[@ldrouard](https://github.com/ldrouard) in
[#4460](#4460)
- **(registry)** added hadolint from aqua registry by
[@ldrouard](https://github.com/ldrouard) in
[#4456](#4456)
- **(shim)** Windows shim add hardlink & symlink mode by
[@qianlongzt](https://github.com/qianlongzt) in
[#4409](#4409)
- **(ubi)** add option `rename_exe` by
[@wlmitch](https://github.com/wlmitch) in
[#4512](#4512)
- use aqua for hk by [@jdx](https://github.com/jdx) in
[f68de38](f68de38)
- add bazel-watcher to registry by
[@betaboon](https://github.com/betaboon) in
[#4296](#4296)

### 🐛 Bug Fixes

- behavior of .disable-self-update by
[@ZeroAurora](https://github.com/ZeroAurora) in
[#4476](#4476)
- devcontainer by [@acesyde](https://github.com/acesyde) in
[#4483](#4483)
- mise outdated --json does not return json if all tools are up-to-date
by [@roele](https://github.com/roele) in
[#4493](#4493)
- bug when using mise use -g when MISE_ENV is filled by
[@roele](https://github.com/roele) in
[#4494](#4494)
- config of symlink tracked on windows is not respected by
[@NavyD](https://github.com/NavyD) in
[#4501](#4501)
- pruning unused tool leaves broken symlinks by
[@roele](https://github.com/roele) in
[#4507](#4507)

### 📚 Documentation

- Fixes typo in lang/zig by [@carldaws](https://github.com/carldaws) in
[#4497](#4497)
- Fix activation on PowerShell by
[@kit494way](https://github.com/kit494way) in
[#4498](#4498)

### Chore

- remove aur job by [@jdx](https://github.com/jdx) in
[fe5a71d](fe5a71d)
- remove reference to aur in release script by
[@jdx](https://github.com/jdx) in
[0824490](0824490)
- deny ring sec by [@jdx](https://github.com/jdx) in
[08e334c](08e334c)

### New Contributors

- @betaboon made their first contribution in
[#4296](#4296)
- @ldrouard made their first contribution in
[#4456](#4456)
- @qianlongzt made their first contribution in
[#4409](#4409)
- @wlmitch made their first contribution in
[#4512](#4512)
- @carldaws made their first contribution in
[#4497](#4497)
- @ZeroAurora made their first contribution in
[#4476](#4476)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants