fix: lowercase desired shim names #4333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug on macOS where we are searching for a shim name with one or more characters uppercased, e.g. Python. But on macOS the APFS (default file system) is case insensitive, so `mise doctor` will always report an error in this case.
KevSlashNull
force-pushed
the
lowercase-desired-shims
branch
from
2016098 to
554a043
Compare
|
do you have an example of a tool that has a bin with an uppercase name? is this a specific python flavor or something? |
|
@jdx, I assume it's something specific to the Python plugin but I don't really use Python and I also uninstalled the plugin during debugging and it still showed the doctor error. I'll check on Monday when I'm back at my work laptop, and see where that shim is coming from. It doesn't happen on Linux seemingly. |
jdx
pushed a commit
that referenced
this pull request
Feb 14, 2025
### 🚀 Features - **(registry)** add e1s by [@kiwamizamurai](https://github.com/kiwamizamurai) in [#4363](#4363) - **(registry)** add 'marksman' via 'aqua:artempyanykh/marksman' backend by [@iamoeg](https://github.com/iamoeg) in [#4357](#4357) - use `machengine.org` for downloading nominated zig versions by [@hadronomy](https://github.com/hadronomy) in [#4356](#4356) ### 🐛 Bug Fixes - **(aqua)** apply override of version_prefix by [@risu729](https://github.com/risu729) in [#4338](#4338) - **(env_directive)** apply redactions only to env with redact by [@risu729](https://github.com/risu729) in [#4388](#4388) - **(hook_env)** don't exit early if watching files are deleted by [@risu729](https://github.com/risu729) in [#4390](#4390) - **(rubygems_plugin)** Replace which ruby check for Windows compatibility by [@genskyff](https://github.com/genskyff) in [#4358](#4358) - lowercase desired shim names by [@KevSlashNull](https://github.com/KevSlashNull) in [#4333](#4333) - allow cosign opts to be empty in aqua by [@IxDay](https://github.com/IxDay) in [#4396](#4396) ### 📚 Documentation - update Fedora install for dnf5 by [@rkben](https://github.com/rkben) in [#4387](#4387) - fix links to idiomatic version file option by [@pietrodn](https://github.com/pietrodn) in [#4382](#4382) - add mise bootstrap example in CI docs by [@hverlin](https://github.com/hverlin) in [#4351](#4351) - Update link in comparison-to-asdf.md by [@hverlin](https://github.com/hverlin) in [#4401](#4401) ### 📦️ Dependency Updates - update rust crate bzip2 to v0.5.1 by [@renovate[bot]](https://github.com/renovate[bot]) in [#4392](#4392) - update rust crate built to v0.7.6 by [@renovate[bot]](https://github.com/renovate[bot]) in [#4391](#4391) ### Chore - issue closer by [@jdx](https://github.com/jdx) in [bee1f55](bee1f55) ### New Contributors - @iamoeg made their first contribution in [#4357](#4357) - @hadronomy made their first contribution in [#4356](#4356) - @pietrodn made their first contribution in [#4382](#4382) - @genskyff made their first contribution in [#4358](#4358) - @kiwamizamurai made their first contribution in [#4363](#4363) - @rkben made their first contribution in [#4387](#4387) - @IxDay made their first contribution in [#4396](#4396) - @KevSlashNull made their first contribution in [#4333](#4333)
|
Thanks for merging and sorry for responding late, @jdx! For posterity, I found the source of the uppercase There exists a binary at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug on macOS where we are searching for a shim name with one or more characters uppercased, e.g. Python. But on macOS the APFS (default file system) is case insensitive, so
mise doctorwill always report an error in this case.See #4332