Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrate a pre-push check #100

Closed
sourabhniyogi opened this issue Feb 25, 2025 · 1 comment
Closed

integrate a pre-push check #100

sourabhniyogi opened this issue Feb 25, 2025 · 1 comment

Comments

@sourabhniyogi
Copy link
Contributor

sourabhniyogi commented Feb 25, 2025

Now that we have a working API endpoint, prior to a pull request going into main on this repo, we'll require a pre-push check to check all the data files from some branch X pass the jamduna matrix endpoint with "ok" for 100% data files as done here.

The end result of this will be that AT LEAST the data files are consistent with the data files.

This doesn't check for the chainspecs (which contain a genesis state) but it will help teams see the data state_transitions as visibly consistent with the jamduna endpoint.

sourabhniyogi added a commit that referenced this issue Feb 27, 2025
Addresses:
* #101 4.7 is the same as 4.17 C
* #100 with prepush check checkstatetransitions.sh 
* Uses "fib2" service to explore more host function testing
@sourabhniyogi
Copy link
Contributor Author

solved in 0.6.2.7

sourabhniyogi added a commit that referenced this issue Feb 27, 2025
Addresses:
* #101 4.7 is the same as 4.17 C
* #100 with prepush check checkstatetransitions.sh
* Uses "fib2" service to explore more host function testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant