FaceletContext: add static utility methods getCurrentInstance() and getCurrentInstance(FacesContext context)

[pizzi80]

Basically the idea is to have the same utility method
similar to FacesContext.getCurrentInstance()

the implementation could be something like:

/**
 * @return the current {@link FaceletContext} from the attributes of the current {@link FacesContext}
 */
public static FaceletContext getCurrentInstance() {
    return getCurrentInstance(FacesContext.getCurrentInstance());
}

/**
 * @return the current {@link FaceletContext} from the attributes of the passed {@link FacesContext}
 * @param context the current FacesContext
 */
public static FaceletContext getCurrentInstance(FacesContext context) {
    return (FaceletContext) context.getAttributes().get(FaceletContext.FACELET_CONTEXT_KEY);
}

[tandraschko]

I cant follow?

[pizzi80]

I'm not sure I've understood...

I'm referring to the following class:

https://github.com/jakartaee/faces/blob/5.0/api/src/main/java/jakarta/faces/view/facelets/FaceletContext.java

[tandraschko]

so you wanna add this 2 new methods?

[pizzi80]

yeah :D

I probably should have specified that ...

[pizzi80]

fixed ;)

[tandraschko]

i think its a good small change to add in 5.0; cc @BalusC

[BalusC]

+1

[hantsy]

If it can be a global static method to get the instance, do not forget to expose it as CDI bean.

[tandraschko]

If it can be a global static method to get the instance, do not forget to expose it as CDI bean.

we dont have something like a FacesRequestScope yet

[BalusC]

FaceletContext has a shorter lifetime than FacesContext as well. And it can be recreated multiple times during a single "Faces Request/Context Scope". It's basically only available during view build time (which can indeed occur multiple times during a Faces request). Hence generally any attempt to obtain it in a normal backing bean is hacky. It makes totally sense in tag handlers and it makes somewhat sense in ui components and should be handled with care and a good understanding of the facelet / uicomponent lifecycle.

Tag handlers and ui components are already no injection targets in first place, so exposing it as CDI bean makes no sense. And indeed as Thomas hinted, a new scope should be introduced therefor, but not "Faces Request/Context Scope".