Native memory leak when writing TIFFs (DEFLATE) #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writing a TIFF using DEFLATE as compression algorithm, a
java.util.zip.Deflate
instance is created. This instance uses native resources, which are only released whenDeflate#end()
is called, or when thefinalize
method is invoked.In order to avoid relying on GC to clean up the native resources through the finalizer, the
TIFFDeflater
class should callend()
when it is disposed. In order to do this, I had to add adispose
method to theTIFFCompressor
class and call it from theTIFFImageWriter
.The
TIFFImageWriter
already has adispose
method, which will now call thedispose
method of theTIFFCompressor
. As a result, everybody who is using theTIFFImageWriter
class correctly (callingdispose
when finished) will benefit from this fix.Inside the
TIFFImageWriter
class, there was abogusWriter
created, on which thedispose
call was lacking. I added this call as well.