-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keyboard arrow key controls for accessibility #142
base: master
Are you sure you want to change the base?
Conversation
@gibinealias Thanks for the pull request. I cannot merge this request because it is globally applied. You've taken away the user's ability to navigate around the page using the arrow keys. Also, the keyboard navigation is applying to every instance of zoom on the page. There has some intent expressed by the user in order to activate keyboard controls to a particular zoomed image, then be some way for the user to release those controls when done. |
1) Avoided global apply of keyboard events. It's now only applied when the zoom is active and destroyed once the zoom is stopped. 2) Set the keyboard navigation option as false by default, which enables the user to activate it on desired images alone.
@jackmoore - Thanks a lot for your prompt response. Really appreciate it. |
Hi everyone, sorry to revive this old discussion. $source.on('focus', function (e) {
start(e);
});
$source.on('blur', function (e) {
stop();
}); This will allow us to start and stop the zoom when the With this, many US websites can be ADA compliant without having to switch to some other zoom plugin 👍 |
@Hecsall - Thanks :) |
Seems good to me, good job! |
No description provided.