Overhaul layout manager #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix views with `fill*` property being measured to wrap children
…icitly during recalculation
|
Fun fact: on the current |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is focused on rebuilding the layout manager. Instead of measuring children at every step it now passes the tree two times at most. The first pass calculates whatever it can and propagates calculated sizes upwards from children to parents. The second pass relies on the propagated values to calculate the rest of the children. Algorithm is more thoroughly explained in the code comments.
In addition to the new algorithm it also adds more complex layout calculations for columns, rows and stacks, which allows creating more complex UIs. It also handles RTL layouts, and adds
isRTLcheck toViewManager.