Sheet: Add more close options and transition timing function #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jialin-he
requested review from
daneah,
mtorres3 and
satya-achanta-venkata
and removed request for
a team
🦋 Changeset detectedLatest commit: a180461 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
chrisjbrown
approved these changes
Sep 26, 2023
daneah
reviewed
Sep 26, 2023
Merged
sirrah-tam
pushed a commit
to sirrah-tam/pharos
that referenced
this pull request
Dec 1, 2023
) * feat(sheet): fix sheet height when click * feat(sheet): emit event for expand and collapse * feat(sheet): add changeset * feat(sheet): make enable expansion an attribute * feat(sheet): close sheet when swipe down or click on overlay * docs(sheet): add change set * feat(sheet): fix bug and set default height * feat(sheet): add unit test * feat(sheet): fix bug * feat(sheet): add height to content * feat(sheet): do not increase sheet high if already full * feat(sheet): expand handle area and fix bug * feat(sheet): remove margin * feat(sheet): fix bug * feat(sheet): only close sheet on overlay with touch screen * feat(sheet): fix bug * feat(sheet): fix bug * feat(sheet): increase handle height for laptop * feat(sheet): set max height to 95% * test(sheet): remove test
daneah
added a commit
that referenced
this pull request
Dec 19, 2023
* develop: A11y revamp: Pharos buttons (non-breaking change) (#628) Radio, Checkbox: Fix group label (#652) Add elevation tokens and documentation (#643) fix(sidenav-link): external link opens in new tab (#645) Upgrade to TypeScript 5 (#644) feat(cli): add newly created components created using pharos-cli to initComponents files (#630) chore: version packages (#640) Coach Mark: Fix react component positioning (#638) Coach Mark: Documentation fixes (#639) chore(deps): bump @babel/traverse from 7.20.0 to 7.23.2 (#637) chore: version packages (#636) Icon: Add Panorama icon (#631) chore: version packages (#629) Loading spinner: add small and on background variant (#627) chore: version packages (#626) Sheet: allow expansion with attribute (#625) fix(button): remove fill on subtle disabled button on background (#618) chore(deps-dev): bump postcss from 8.4.25 to 8.4.31 (#624) chore: version packages (#623) Sheet: Add more close options and transition timing function (#620)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change: (check at least one)
Is this a breaking change? (check one)
Is the: (complete all)
What does this change address?
How does this change work?