Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link checker and fix link errors #76

Merged
merged 11 commits into from
Mar 24, 2023
Merged

Conversation

Alan-Cha
Copy link
Member

Replace #75

Signed-off-by: Alan Cha <[email protected]>
Signed-off-by: Alan Cha <[email protected]>
Signed-off-by: Alan Cha <[email protected]>
Signed-off-by: Alan Cha <[email protected]>
Signed-off-by: Alan Cha <[email protected]>
Signed-off-by: Alan Cha <[email protected]>
Signed-off-by: Alan Cha <[email protected]>
Signed-off-by: Alan Cha <[email protected]>
Signed-off-by: Alan Cha <[email protected]>
Signed-off-by: Alan Cha <[email protected]>
@Alan-Cha
Copy link
Member Author

  • Add link checker workflow that will run whenever there is push/PR to main as well as periodically
  • Fix previously broken links
  • Use GitHub markdown to add images instead of injecting HTML (link checker does not like the file paths in HTML)
    • Resize images that needed resizing

Other things to note:

  • Added .lycheeignore file (containing URLs to ignore during link checking)
    • Various links had to be included due to timeouts, too many redirects, and other various reasons

@Alan-Cha Alan-Cha mentioned this pull request Mar 24, 2023
@@ -0,0 +1,8 @@
http://localhost:8000/

https://dzone.com/articles/automated-performance-testing-with-argocd-and-iter8
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, link checker doesn't like this one.

http://localhost:8000/

https://dzone.com/articles/automated-performance-testing-with-argocd-and-iter8
https://twitter.com/Iter8Tools
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Time out

https://dzone.com/articles/automated-performance-testing-with-argocd-and-iter8
https://twitter.com/Iter8Tools

https://raw.githubusercontent.com/*
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link checker seems to have issues with files that begin with a underscore.

https://twitter.com/Iter8Tools

https://raw.githubusercontent.com/*
https://kserve.github.io/*
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Certificates error

Copy link
Member

@sriumcp sriumcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sriumcp sriumcp merged commit ffc344d into iter8-tools:main Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants