Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document warmup options #70

Merged
merged 2 commits into from
Mar 6, 2023
Merged

document warmup options #70

merged 2 commits into from
Mar 6, 2023

Conversation

kalantar
Copy link
Member

@kalantar kalantar commented Mar 3, 2023

Signed-off-by: Michael Kalantar <[email protected]>
@kalantar kalantar requested review from sriumcp and Alan-Cha March 3, 2023 18:29
@kalantar kalantar self-assigned this Mar 3, 2023
Signed-off-by: Michael Kalantar <[email protected]>
@@ -33,6 +33,8 @@ In addition, the following fields are defined by this task.
| dataURL | string (URL) | URL where JSON data to be used in call requests is located. |
| binaryDataURL | string (URL) | URL where binary data to be used in call requests is located. |
| metadataURL | string (URL) | URL where the JSON metadata data to be used in call requests is located. |
| warmupNumRequests | int | Number of requests to be sent in a warmup task (results are ignored). |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| warmupNumRequests | int | Number of requests to be sent in a warmup task (results are ignored). |
| warmupNumRequests | int | Number of requests to be sent in a warmup task (results are ignored). |

Copy link
Member

@sriumcp sriumcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sriumcp sriumcp merged commit 1d3ad3e into iter8-tools:main Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants