Remove dependency on webContents.history #2836
Conversation
|
I tested this manually and back-forward navigation seems to work almost as well as before. I did notice that this introduces a minor bug which is that you can't (easily) go back from the Explore page; it goes to Also it occurs to me that deleting this much code is pretty fishy, even to me. If I'm way out of line, I wouldn't be surprised. But this just seemed like the easiest path forward. |
The history field of Electron's webContents module is no longer present beyond Electron 10, so we have to stop using it in order to upgrade. webContents.history is ostensibly used to manage a subset of browsing history. My observation is that the global history (which includes itch:// URLs) is a superset of the webContents.history, so the theory is that we could rely entirely on the global history and back-forward navigation would work just as well. This commit introduces a new bug: after entering a URL such as `http://itch.io` into the address bar, the app will change the URL to `https://itch.io/` (note the change in protocol and the added trailing slash), and the history will end up with two entries when there should be only one. This means that going back from `https://itch.io/` will navigate to `http://itch.io` only to loop you back to `https://itch.io/`, rendering the back button useless in this particular scenario. I can't figure out how to fix this correctly, so to work around this in the common case, I'm changing the URL of the Explore sidebar entry so that at least the itch.io homepage won't have this problem. Closes itchio#2598
|
Updated this PR with 3 changes:
At this point the only problem is that if you manually type a URL (e.g. |
|
Thanks for the contribution. I also spent time time investigating this. I think that at this point working on getting electron updated is more important that the bug that's left from removing the custom navigation code. There's a lot of refactoring that needs to take place going forward but I'm happy to accept this so we can push out a build with electron 11 at least. |
The history field of Electron's webContents module is no longer present
beyond Electron 10, so we have to stop using it in order to upgrade.
webContents.history is used to manage a subset of browsing history
within the app. My observation is that the global history (which
includes itch:// URLs) is a superset of the webContents.history, so the
theory is that we could rely entirely on the global history and
back-forward navigation would work just as well.
Closes #2598