[server] views: comments: Check using get(), not 'in' #895
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
CHANGES.rst
because this is a user-facing change or an important bugfixWhat changes does this Pull Request introduce?
Previously, if a dict item was supplied by the JS client but contained an invalid value such as
null
, the server would only check if the dict key was provided, not if its value was falsy.Instead, use
.get()
and check if the value is empty. Then, for instance, attempt to parse thread uris if payload title is invalid instead of simply acceptingnull
as thread title.Also add a test to check this behavior.
Why is this necessary?
Fixes: #874