Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

js: isso: Fix class selector for preview #840

Merged
merged 1 commit into from
Apr 23, 2022

Conversation

ix5
Copy link
Member

@ix5 ix5 commented Apr 23, 2022

The selector also needs the isso- prefix, else the DOM selection fails and the subsequent code gets a null obj, which then fails.

This was overlooked in 85f3954
"js: app/isso: Prefix localstorage keys w/ isso-"

Fixes #839

The selector also needs the `isso-` prefix, else the
DOM selection fails and the subsequent code gets a null obj,
which then fails.

This was overlooked in 85f3954
"js: app/isso: Prefix localstorage keys w/ isso-"

Fixes isso-comments#839
@ix5 ix5 added client (Javascript) client code and CSS bug labels Apr 23, 2022
@ix5 ix5 added this to the 0.13 milestone Apr 23, 2022
@ix5 ix5 merged commit 6d2b284 into isso-comments:master Apr 23, 2022
@ix5 ix5 deleted the bugfix/js-preview-class branch April 23, 2022 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug client (Javascript) client code and CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[client] Uncaught TypeError when pressing preview
1 participant