[api] add EstimateGasForNonExecution in coreservice #3174
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3174 +/- ##
==========================================
- Coverage 75.07% 75.00% -0.07%
==========================================
Files 227 227
Lines 21272 21329 +57
==========================================
+ Hits 15970 15998 +28
- Misses 4465 4481 +16
- Partials 837 850 +13
Continue to review full report at Codecov.
|
api/coreservice.go
Outdated
| gas, err := action.CalculateIntrinsicGas(intrinsicGas, payloadGas, payloadSize) | ||
| if err != nil { | ||
| return 0, err | ||
| } | ||
| return gas, err |
There was a problem hiding this comment.
return action.CalculateIntrinsicGas(intrinsicGas, payloadGas, payloadSize)
api/coreservice.go
Outdated
| switch act := actType.(type) { | ||
| case *action.Transfer: | ||
| intrinsicGas, payloadGas, payloadSize = action.TransferBaseIntrinsicGas, action.TransferPayloadGas, uint64(len(payload)) |
There was a problem hiding this comment.
it is a bit weird to have gas estimation calculation outside of action.Action and hardcoded in core service instead in this way.
There was a problem hiding this comment.
Should EstimateGasForNonExecution() be moved to action.go?
api/web3server_utils.go
Outdated
| return action.NewExecution(to, tx.Nonce(), tx.Value(), tx.Gas(), tx.GasPrice(), tx.Data()) | ||
| case address.StakingProtocolAddr: | ||
| data := tx.Data() | ||
| if len(data) <= 4 { |
There was a problem hiding this comment.
Will use action.NewStakingActionFromABIBinary(tx.Data()) in #3095
api/coreservice.go
Outdated
| func (core *coreService) CalculateGasConsumption(intrinsicGas, payloadGas, payloadSize uint64) (uint64, error) { | ||
| return action.CalculateIntrinsicGas(intrinsicGas, payloadGas, payloadSize) | ||
| // EstimateGasForNonExecution estimates action gas except execution | ||
| func (core *coreService) EstimateGasForNonExecution(actType action.Action, payload []byte) (uint64, error) { |
api/grpcserver.go
Outdated
| if err := tmpAct.LoadProto(in.GetTransfer()); err != nil { | ||
| return nil, status.Error(codes.InvalidArgument, err.Error()) | ||
| } | ||
| act, payload = tmpAct, tmpAct.Payload() |
There was a problem hiding this comment.
estimatedGas, err = tmpAct.IntrinsicGas()
api/grpcserver.go
Outdated
| if err := tmpAct.LoadProto(in.GetStakeCreate()); err != nil { | ||
| return nil, status.Error(codes.InvalidArgument, err.Error()) | ||
| } | ||
| act, payload = tmpAct, tmpAct.Payload() |
There was a problem hiding this comment.
estimatedGas, err = tmpAct.IntrinsicGas()
api/grpcserver.go
Outdated
| if err := tmpAct.LoadProto(in.GetStakeUnstake()); err != nil { | ||
| return nil, status.Error(codes.InvalidArgument, err.Error()) | ||
| } | ||
| act, payload = tmpAct, tmpAct.Payload() |
follows #3095