Skip to content
This repository was archived by the owner on Jun 7, 2023. It is now read-only.

Mobile: Handle error if permissions are denied on SeedVault import #719

Merged
merged 3 commits into from
Dec 10, 2018

Conversation

rajivshah3
Copy link
Member

Description

Shows a dropdown explaining that file system permissions are required instead of throwing an error

Type of change

  • Bug fix (a non-breaking change which fixes an issue)

How Has This Been Tested?

  • Tested on Pixel 2 simulator

Checklist:

  • My code follows the style guidelines for this project
  • I have performed a self-review of my own code
  • New and existing unit tests pass locally with my changes

@rajivshah3 rajivshah3 added T - Bug Type - Bug: Something isn't working C - Mobile L - Need reviews Lifecycle - Each PR must have at least two reviewers E - Functional Epic - Relating to how a feature works labels Dec 9, 2018
@rajivshah3 rajivshah3 merged commit a9aa824 into develop Dec 10, 2018
@rajivshah3 rajivshah3 deleted the fix/handle-permissions-denied branch December 10, 2018 20:14
rihardsgravis pushed a commit that referenced this pull request Dec 12, 2018
* develop: (141 commits)
  New Crowdin translations [ci skip] (#769)
  Mobile: Fix minor bugs (#771)
  Assign account index to accounts in state (#715)
  Mobile: Fix failing tests (#770)
  Desktop: Add two-factor authorisation to Password modal (#764)
  Localization improvements (#718)
  Mobile: Fix keyboard avoidance globally (#767)
  Mobile: Handle error if permissions are denied on SeedVault import (#719)
  New Crowdin translations [ci skip] (#667)
  Desktop: Delete yarn.lock (#768)
  Update Seed write down view `Done` locale to `Back` (#765)
  Mobile: Minor refactor
  Update src/mobile/android/gradlew.bat
  Mobile: Minor code cleanup
  Fix unresolved conflict
  Localise string
  Update src/mobile/src/ui/views/wallet/DeleteAccount.js
  Update src/mobile/src/ui/components/TransferConfirmationModal.js
  Preserve order of themes via indexes in ThemeCustomisation component (#763)
  [Security] Bump lodash from 4.17.4 to 4.17.10 (#723)
  ...

# Conflicts:
#	src/desktop/src/ui/views/account/Addresses.js
#	src/desktop/src/ui/views/settings/Advanced.js
#	src/desktop/src/ui/views/settings/account/Seed.js
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C - Mobile E - Functional Epic - Relating to how a feature works L - Need reviews Lifecycle - Each PR must have at least two reviewers T - Bug Type - Bug: Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants