Skip to content
This repository was archived by the owner on Jun 7, 2023. It is now read-only.

Mobile: Reenable and refactor deep linking #1143

Merged
merged 352 commits into from
Apr 8, 2019
Merged

Mobile: Reenable and refactor deep linking #1143

merged 352 commits into from
Apr 8, 2019

Conversation

cvarley100
Copy link
Contributor

@cvarley100 cvarley100 commented Feb 27, 2019 •
edited
Loading

Description

  • Moves mobile deep linking to HOC

To do:

  • Move desktop deep linking to HOC
  • Add migration function for deepLinking setting
  • Add mobile UI
  • Add desktop UI

Type of change

  • Enhancement (a non-breaking change which adds functionality)

How Has This Been Tested?

  • Tested on Android and iOS

Checklist:

  • My code follows the style guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes
  • For changes to mobile that include native code (including React Native modules): I have verified that both iOS and Android successfully build in both Debug and Release modes
  • For changes to shared: If applicable, I have verified that my changes are implemented correctly in desktop and mobile

cvarley100 and others added 30 commits December 19, 2018 17:45
@cvarley100
Shared: Localise strings
93a2580
@cvarley100
Mobile: Update transaction history modal buttons
ab838dc
@laumair
Merge branch develop into branch feature/realm
79214b8
@laumair
Merge remote-tracking branch 'upstream/develop' into test/desktop-init
9e6ce6d
@laumair
Merge branch develop into branch feature/realm
c888501
@laumair
Merge branch test/desktop-init into branch feature/realm
40f5091
@cvarley100
Mobile: Adjust topbar scrollable
72f6193
@laumair
Node Quorum (#631)
ed56029 
* Implement quorum for wereAddressesSpentFrom

* Simply #findSyncedNodes implementation

* Add quorum support for getBalances IRI endpoint

* Minor updates

- Add quorum support for getTrytes IRI endpoint
- Minor clean up in quorum methods

* Add quorum support for findTransactions IRI endpoint

* Rename quorum methods for better readability

* Integrate quorum methods with extended api

* Remove findTransactions & getTrytes endpoints from quorum

* Refactor quorum implementation and do minor fixes

- Update JSDoc typos
- Simplify quorum implementation (Remove duplications)
- Add a timeout for network request to each node
- Fix issues in findSyncedNodes implementation
- Update error messages

* Add coverage
- Add coverage for #determineQuorumResult
- Add coverage for #fallbackToSafeResult
- Add coverage for #findSyncedNodes

* Add empty payload checks in quorum methods

* Wrap percentage calculation in parentheses for clarity

Co-Authored-By: laumair <[email protected]>

* Use develop branch of iota.lib.js

* Enforce quorum (by default) on supported methods

* Fix tests failing because of quorum enforcement

* Add code documentation and rename parameters & variables for clarity

- Related discussion #631 (comment)

* [Security] Bump cryptiles from 3.1.2 to 3.1.4 (#829)

* [Security] Bump nokogiri from 1.8.4 to 1.9.1 in /src/mobile/android (#828)

* Make sure accounts are always iterated in correct order (by account index) (#824)

Object.keys(<object>) function does not always preseve the order, especially if the object key starts with a number. This causes an issue when Object.keys is used for iterating on account names. #715 adds account indexes to state to make sure the order of accounts is always intact. However, some components in desktop use Object.keys directly on accounts object, which leads to certain issues of incorrect references to accounts. This commit fixes this issue by replacing Object.keys implementation on accounts with getAccountNamesFromState selector that guarantees the accounts order.

Fixes #811

Note that the issues Object.keys create are not always noticeable. Steps to reproduce these issues are:

- Add account with name "M"
- Add another account with name "0"
- Notice account names order in sidebar (Instead of "0" being the second account, it becomes the first)
- Generate receive address from account "M" (Instead of generating receive address for account "M", it generates receive address for account "0")

* New Crowdin translations [ci skip] (#826)

* New translations translation.json (Czech)

* New translations translation.json (Czech)

* New translations translation.json (Japanese)

* New translations translation.json (Spanish)

* Mobile: Update findSyncedNodes

* Update quorum.js

* Improve parameters and variable names

* Include custom nodes in quorum nodes

* Reduce node request timeout for getNodeInfo api calls (in quorum)
@cvarley100
Mobile: Minor cleanup
999a836
@cvarley100
Merge branch 'mobile-0.6.0-alpha-quorum' of https://github.com/iotale…
fb862f5 
…dger/trinity-wallet into mobile-0.6.0-alpha-quorum
@rajivshah3 @cvarley100
Mobile: Bump build numbers for release v0.6.0 (33) (#808)
4b8c143
@cvarley100
Merge branch 'develop' into mobile-0.6.0-alpha-quorum
0686258
@cvarley100
Merge branch 'mobile-0.6.0-alpha-quorum' of https://github.com/iotale…
8af140e 
…dger/trinity-wallet into mobile-0.6.0-alpha-quorum
@cvarley100
Mobile: Bump build no
7608dc6
@cvarley100
Mobile: Fix account name opacity during certain tasks
d45ff9b
@cvarley100
Mobile: Adjust chart animations
e419509
@cvarley100
Mobile: Adjust chart timeframe order
abc53c8
@rajivshah3 @laumair
Shared: Rebuild realm after installing dependencies (#842)
2559982
@laumair
Merge branch 'mobile-alpha/realm' into feature/realm
a47e54c
@laumair
Merge remote-tracking branch 'upstream/feature/realm' into feature/realm
6a4813f
@laumair
Remove undefined i18next translate function from progressSteps
84411b2
@cvarley100
Mobile: Replace seed and password usage with global instance
764d488
@rajivshah3 @cvarley100
Mobile: Add ability to force GC on iOS
1e0264d
@rajivshah3 @cvarley100
Mobile: Work on forced garbage collection for Android
3b133f6
@cvarley100
Resolve conflicts
667c901
@cvarley100
Mobile: Link Android GarbageCollector
783b2cc
@laumair
Update prepateTransferArray implementation to accept addressData as a…
e3561de 
…n array instead of an object
@laumair
Merge branch mobile-alpha/realm into branch feature/realm
312dc5e
@laumair
Minor fixes and updates
5996a50 
- Remove manual state rehydration from src/desktop/src/index.js
- Pass in theme object to UnitInfoModal
- Fix JSDocs for addCustomNodeSuccess action creator
- Fix notificationFn trigger in syncAccount
- Relocate mapNormalisedTransactions util
@laumair
Always find transaction hashes diff from transactions with own addresses
c11e7d4
@laumair
Copy link
Contributor

laumair commented Feb 28, 2019

@cvarley100 Is this only awaiting migrations?

@cvarley100
Copy link
Contributor Author

@laumair No, it also needs settings UI and associated checks.

@rajivshah3 rajivshah3 added L - WIP Lifecycle - Work in Progress C - Mobile C - Desktop labels Feb 28, 2019
@laumair laumair mentioned this pull request Mar 4, 2019
Closed
@cvarley100 cvarley100 mentioned this pull request Mar 4, 2019
Closed
This was referenced Apr 3, 2019
Closed
Merged
@cvarley100 cvarley100 requested a review from rajivshah3 April 8, 2019 13:29
@cvarley100 cvarley100 changed the title Shared: Reenable and refactor deep linking Mobile: Reenable and refactor deep linking Apr 8, 2019
@rajivshah3 rajivshah3 added T - Enhancement New feature or request and removed C - Desktop L - WIP Lifecycle - Work in Progress labels Apr 8, 2019
rajivshah3
rajivshah3 suggested changes Apr 8, 2019
View reviewed changes
@cvarley100 cvarley100 merged commit 5ebb5fe into develop Apr 8, 2019
rihardsgravis pushed a commit that referenced this pull request Apr 12, 2019
Merge branch 'develop' into desktop-test-coverage
3ac6d01 
* develop: (155 commits)
  Bump electron from 3.1.6 to 3.1.8 in /src/desktop (#1294)
  Bump react-transition-group from 2.7.1 to 2.9.0 in /src/desktop (#1273)
  Bump css-loader from 2.1.0 to 2.1.1 in /src/desktop (#1262)
  Bump electron-builder from 20.38.5 to 20.39.0 in /src/desktop (#1261)
  Bump @ledgerhq/hw-transport-node-hid in /src/desktop (#1290)
  Bump snyk from 1.149.0 to 1.150.0 (#1289)
  Bump fastlane from 2.119.0 to 2.120.0 in /src/mobile/ios (#1288)
  Bump fastlane from 2.119.0 to 2.120.0 in /src/mobile/android (#1287)
  Bump snyk from 1.148.0 to 1.149.0 (#1286)
  Shared: Add node request timeouts for getTransactionsToApprove endpoint (#1284)
  Mobile: Wait for SeedStore constructor promise to resolve before making a retry attempt (#1283)
  Bump snyk from 1.147.4 to 1.148.0 (#1279)
  Mobile: Minor changes to seed text input (#1244)
  New Crowdin translations (#1252)
  Mobile: Reenable and refactor deep linking (#1143)
  Only convert transactions to normalised transactions if notification function is defined (#1276)
  feat: add realm migration from v1 to v2 (#1274)
  Mobile: Fix AsyncStorage migration (#1272)
  Bump webpack-dev-middleware from 3.6.0 to 3.6.2 in /src/desktop (#1264)
  Bump snyk from 1.147.3 to 1.147.4 (#1270)
  ...

# Conflicts:
#	package.json
#	src/desktop/native/Entangled.js
#	src/desktop/package.json
#	src/desktop/src/index.js
#	src/desktop/src/libs/crypto.js
#	src/desktop/src/ui/components/Balance.js
#	src/desktop/src/ui/components/List.js
#	src/desktop/src/ui/global/Theme.js
#	src/desktop/src/ui/views/settings/account/Addresses.js
#	src/desktop/src/ui/views/wallet/Sidebar.js
#	src/shared/libs/currency.js
@rajivshah3 rajivshah3 deleted the feat/deep-links branch April 15, 2019 17:58
This was referenced Apr 16, 2019
Closed
Merged
@cvarley100 cvarley100 mentioned this pull request May 7, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rajivshah3 rajivshah3 rajivshah3 approved these changes

Assignees
No one assigned
Labels
C - Mobile T - Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cvarley100 @laumair @rajivshah3 @rihardsgravis @iotasyncbot