This repository was archived by the owner on Aug 23, 2020. It is now read-only.
Revert milestone sorting #1747
Merged
Revert milestone sorting #1747
+8
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lidification (iotaledger#1660)" This reverts commit b658b88.
GalRogozinski
approved these changes
Feb 11, 2020
There was a problem hiding this comment.
Thanks
Apparently Travis is still having problems...
Now I am not sure if caching did something or they changed something on their servers
I think we need to start doing Travis builds on old versions to see what happens with them..
but of course this PR is good :-)
kwek20
pushed a commit
to kwek20/iri
that referenced
this pull request
Mar 10, 2020
…lidification (iotaledger#1660)" (iotaledger#1747) This reverts commit b658b88.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit b658b88.
Description
In DB's with large collections of milestones, the
LatestMilestoneTrackergets stalled out in the collection phase as it tries to create and sort all the milestone transaction objects. This can also cause memory errors in large enough db's and can stall out the milestone tracking process.Type of change
How Has This Been Tested?
Checklist: