Skip to content
This repository was archived by the owner on Aug 23, 2020. It is now read-only.

Adds config option to disable sync progress printing #1649

Merged
merged 1 commit into from
Oct 29, 2019
Merged

Conversation

luca-moser
Copy link
Member

Description

Adds an option to disable the printing of progress information to the console about synchronization. This is useful for Dyrell who's spamming milestones in a fast fashion, where however the printing of the progress bar slows down that process too much for generating DBs.

Type of change

  • Enhancement (a non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@luca-moser luca-moser requested a review from DyrellC October 29, 2019 09:37
Copy link
Contributor

@DyrellC DyrellC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks this should make it much easier for me to make DB's for tests now.

@luca-moser luca-moser merged commit 2533565 into dev Oct 29, 2019
@GalRogozinski GalRogozinski deleted the prog-bar-opt branch November 27, 2019 13:04
@GalRogozinski GalRogozinski mentioned this pull request May 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants