This repository was archived by the owner on Aug 23, 2020. It is now read-only.
Fix: fixes spent states of addresses not getting persisted on tx pruning #1437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a node only boots up with a database (without spent-addresses-db) and the node has LS pruning enabled, then the node will prune everything below the given thresholds but not persist the spent state of the corresponding addresses. This commit fixes the issue by replacing the spentAddressesService's wasAddressSpentFrom() with a simple check against the persistence layer (spentAddressesProvider.containsAddress()) in order to ensure, that the spent state is correctly persisted. Previously the check would always return true, making it so that the address was never persisted as spent. Signed-off-by: Luca Moser <[email protected]>
GalRogozinski
approved these changes
May 7, 2019
| @@ -67,6 +68,11 @@ | |||
| */ | |||
| private SpentAddressesService spentAddressesService; | |||
|
|
|||
| /** | |||
| * Used to check whether an address is already persisted in the persistence layer. | |||
| */ | |||
There was a problem hiding this comment.
I just want to let you know my opinion.
These types of comments could have simply been placed only on the SpentAddressProvider class file and that's it. Via an IDE you could read it from all classes that use it as dependency.
Right now putting such a comment in every place we use the SpentAddressProvider is kind of repetitive, and pretty much violates DRY (do not repeat yourself). If we want to change the comment we have to change it in multiple places.
The reason we have those is because Hans, who did a great job, really liked to have them everywhere.
Having said that, since currently the entire class looks like this, it is perfectly ok that you added the comment and no need to remove it now.
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If a node only boots up with a database (without spent-addresses-db) and the node has LS pruning enabled, then the node will prune everything below the given thresholds but not persist the spent state of the corresponding addresses.
This commit fixes the issue by replacing the spentAddressesService's wasAddressSpentFrom() with a simple check against the persistence layer (spentAddressesProvider.containsAddress()) in order to ensure, that the spent state is correctly persisted. Previously the check would always return true, making it so that the address was never persisted as spent.
Signed-off-by: Luca Moser [email protected]
Type of change
How Has This Been Tested?
In the ICC network with a node with a very short pruning delay which correctly reported the "genesis" address which held the 2.7Pi as spent, even after pruning the given transaction. (the transaction itself wasn't available anymore via
getTrytes).Checklist: