This repository was archived by the owner on Sep 6, 2024. It is now read-only.

Retain original behavior of addChecksum #360

Merged

chrisdukakis merged 1 commit into iotaledger:develop from rajivshah3:fix/add-checksum

Feb 22, 2019

Member

rajivshah3 commented Feb 22, 2019 •

edited

Loading

Description

Retains the original behavior of addChecksum

Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tests pass

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes


          Retain original behavior of addChecksum

5a98f0d

chrisdukakis approved these changes

View reviewed changes

Contributor

chrisdukakis left a comment

LGTM, also complies with

iota.js/packages/checksum/src/index.ts

Line 70 in 77dabb0

return input.concat(trytes(checksumTrits.slice(243 - checksumLength * 3, 243)))

👍

chrisdukakis merged commit eb27c18 into iotaledger:develop

rajivshah3 deleted the fix/add-checksum branch

February 22, 2019 04:56

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet