Merge pull request #360 from rajivshah3/fix/add-checksum

Retain original behavior of addChecksum
iotaledger · Feb 22, 2019 · eb27c18 · eb27c18
2 parents afe95db + 5a98f0d
commit eb27c18
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/lib/utils/utils.js b/lib/utils/utils.js
@@ -38,7 +38,7 @@ var convertUnits = function(value, fromUnit, toUnit) {
         throw new Error("Invalid unit provided");
     }
 
-    var valueBn = new BigNumber(value); 
+    var valueBn = new BigNumber(value);
 
     if(valueBn.dp() > unitMap[fromUnit].dp) {
       throw new Error("Input value exceeded max fromUnit precision.");
@@ -110,7 +110,7 @@ var addChecksum = function (inputValue, checksumLength, isAddress) {
         var fallbackLength = isTrytes ? 9 : 27;
         var length = checksumLength || fallbackLength;
 
-        return value.concat(checksum.slice(0, length));
+        return value.concat(checksum.slice(-length));
     };
 
     var result = input.map(withChecksum);

diff --git a/test/utils/utils.checksum.js b/test/utils/utils.checksum.js
@@ -69,7 +69,7 @@ describe('utils.checksum', function () {
                     var checksumLength = 3;
 
                     validAddressData.forEach(function (data) {
-                        expect(Utils.addChecksum(data.address, checksumLength)).to.equal(data.address + data.checksum.slice(0, checksumLength));
+                        expect(Utils.addChecksum(data.address, checksumLength)).to.equal(data.address + data.checksum.slice(-checksumLength));
                     });
                 });
             });
@@ -103,7 +103,7 @@ describe('utils.checksum', function () {
 
                     expect(actualAddressesWithChecksum).to.eql(expectedAddressesWithChecksum);
                 });
-                
+
                 it('should have correct checksum length', function () {
                     var checksumLength = 4;
 
@@ -115,7 +115,7 @@ describe('utils.checksum', function () {
                     );
 
                     var expectedAddressesWithChecksum = validAddressData.map(function (data) {
-                        return data.address + data.checksum.slice(0, checksumLength);
+                        return data.address + data.checksum.slice(-checksumLength);
                     });
 
                     expect(actualAddressesWithChecksum).to.eql(expectedAddressesWithChecksum);
@@ -176,11 +176,11 @@ describe('utils.checksum', function () {
 
                     addressData.forEach(function (data) {
                         var addressTritsWithChecksum = Utils.addChecksum(data.address, tritsChecksumLength);
-                        expect(addressTritsWithChecksum).to.eql(data.address.concat(data.checksum.slice(0, tritsChecksumLength)));
+                        expect(addressTritsWithChecksum).to.eql(data.address.concat(data.checksum.slice(-tritsChecksumLength)));
 
                         // Also assert on trytes
                         expect(Converter.trytes(addressTritsWithChecksum)).to.equal(
-                            Converter.trytes(data.address).concat(Converter.trytes(data.checksum).slice(0, trytesChecksumLength))
+                            Converter.trytes(data.address).concat(Converter.trytes(data.checksum).slice(-trytesChecksumLength))
                         );
                     });
                 });
@@ -253,7 +253,7 @@ describe('utils.checksum', function () {
                         tritsChecksumLength
                     );
                     var expectedTritArray = addressData.map(function (data) {
-                        return data.address.concat(data.checksum.slice(0, tritsChecksumLength));
+                        return data.address.concat(data.checksum.slice(-tritsChecksumLength));
                     });
 
                     expect(actualTritArray).to.eql(expectedTritArray);