-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the crate description for identity-credential
#873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
identity-credential
eike-hass
reviewed
Jun 10, 2022
eike-hass
reviewed
Jun 10, 2022
cycraig
suggested changes
Jun 10, 2022
Co-authored-by: cycraig <[email protected]>
Co-authored-by: cycraig <[email protected]>
Co-authored-by: cycraig <[email protected]>
Co-authored-by: cycraig <[email protected]>
Co-authored-by: cycraig <[email protected]>
Co-authored-by: cycraig <[email protected]>
Co-authored-by: cycraig <[email protected]>
Co-authored-by: cycraig <[email protected]>
Co-authored-by: cycraig <[email protected]>
Co-authored-by: cycraig <[email protected]>
cycraig
reviewed
Jun 13, 2022
All comments have been addressed. |
cycraig
approved these changes
Jun 13, 2022
eike-hass
approved these changes
Jun 13, 2022
b2ec181
to
44c8d85
Compare
cycraig
reviewed
Jun 13, 2022
Closed
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Updates the crate description for
identity-credential
to contain a basic description, some simple examples and links out to other relevant pages such as our wiki and project level examples.Links to any relevant issues
Issues #133 and #869 need this PR.
Type of change
Add an
x
to the boxes that are relevant to your changes.How the change has been tested
Checked that the documentation looks OK with
cargo doc --open
(inside theidentity-credential
directory) . All warnings reported are from other crates in the workspace.Also runs locally under
cargo test
(which runs the examples in the README.md).Change checklist
Add an
x
to the boxes that are relevant to your changes.