DPPA-1123 Rename mibitracker-client to mibilib #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murataksoy
reviewed
Aug 26, 2020
| channels: | ||
| - conda-forge | ||
| - defaults | ||
| dependencies: | ||
| - pip=19.1.1 | ||
| - python=3.7.3 | ||
| - pip: | ||
| - astroid==2.2.5 |
There was a problem hiding this comment.
Why was this change necessary? It seems to conflict with the mibitof version.
There was a problem hiding this comment.
astroid is a dependency of pylint and the version it was pulling caused it to error (see circleci failure). ultimately we should fix it by updating the pylint version but that should be a separate ticket since we may need to adjust settings. pylint-dev/pylint#2388
murataksoy
approved these changes
Aug 26, 2020
rfinck
pushed a commit
that referenced
this pull request
Aug 26, 2020
* mibitracker-client -> mibilib * Update notebook urls. * Fix pylint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.