feat(radio-group): add helperText and errorText properties #30222
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
package: core
core/src/components/radio-group/test/supporting-text/index.html
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| .ion-touched.ion-invalid .radio-group-top .helper-text { | ||
| display: none; |
There was a problem hiding this comment.
I don't really know if this is worth mentioning, and it may be expected behavior, but this means helper text will be hidden in an invalid state even if there's no error text. That might be confusing, but it's probably a non-issue.
There was a problem hiding this comment.
Correct! I actually mentioned this the other day because this is how both the input and textarea components (the only two that are already released) currently behave. I thought this was a weird behavior, but I didn't change it since it aligns with the existing implementation of those components. Maybe we can revisit this in the future.
There was a problem hiding this comment.
My guess is that developers might want this behavior. I wouldn't be surprised that there are some who don't want the error text but need the classes for them to do their own validation.
There was a problem hiding this comment.
This is also something developers could override if they just want the color to change: https://codepen.io/brandyssmith/pen/emYWeMO?editors=1100
It's not the cleanest but it is possible.
core/src/components/radio-group/test/supporting-text/index.html
Outdated
Show resolved
Hide resolved
core/src/components/radio-group/test/supporting-text/radio-group.e2e.ts
Outdated
Show resolved
Hide resolved
Issue number: N/A
What is the current behavior?
Radio group does not support helper and error text.
What is the new behavior?
Adds support for helper and error text.
Does this introduce a breaking change?
Other information
Dev build:
8.4.4-dev.11741101920.155e1c29