feat(datetime): add showAdjacentDays to display days from the previous and next months #30209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add showDaysOutsideCurrentMonth property to datetime component; - change month generation to respect new property;
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
package: core
JoaoFerreira-FrontEnd
changed the title
- create specific test page for showDaysOutsideCurrentMonth;
JoaoFerreira-FrontEnd
changed the title
BenOsodrac
requested changes
Feb 27, 2025
BenOsodrac
reviewed
Feb 27, 2025
...onth/datetime.e2e.ts-snapshots/custom-wheel-with-hidden-days-ios-ltr-Mobile-Chrome-linux.png
Outdated
Show resolved
Hide resolved
|
@JoaoFerreira-FrontEnd some screenshots are failing, please review this before requesting review 👍 Apart from the comments I already left, I didn't find anything more to comment on! It seems to be working as expected in runtime 💪 |
BenOsodrac
approved these changes
Feb 28, 2025
…datetime.e2e.ts Co-authored-by: Brandy Smith <[email protected]>
…datetime.e2e.ts Co-authored-by: Brandy Smith <[email protected]>
…datetime.e2e.ts Co-authored-by: Brandy Smith <[email protected]>
…datetime.e2e.ts Co-authored-by: Brandy Smith <[email protected]>
…datetime.e2e.ts Co-authored-by: Brandy Smith <[email protected]>
…datetime.e2e.ts Co-authored-by: Brandy Smith <[email protected]>
…datetime.e2e.ts Co-authored-by: Brandy Smith <[email protected]>
…datetime.e2e.ts Co-authored-by: Brandy Smith <[email protected]>
…datetime.e2e.ts Co-authored-by: Brandy Smith <[email protected]>
brandyscarney
changed the title
brandyscarney
requested changes
Mar 7, 2025
Comment on lines
+367
to
+369
| :host .calendar-day.calendar-day-adjacent-day { | ||
| opacity: 0.4; | ||
| } |
There was a problem hiding this comment.
Suggested change
| :host .calendar-day.calendar-day-adjacent-day { | |
| opacity: 0.4; | |
| } |
This is not necessary because the disabled opacity will be applied by the above rule after removing the opacity checks from ios and md.
Comment on lines
+272
to
+273
|
|
||
| opacity: 1; |
There was a problem hiding this comment.
Suggested change
| opacity: 1; |
Comment on lines
+133
to
+134
|
|
||
| opacity: 1; |
There was a problem hiding this comment.
Suggested change
| opacity: 1; |
| @@ -267,6 +267,12 @@ | |||
| color: current-color(contrast); | |||
| } | |||
|
|
|||
| :host .calendar-day.calendar-day-adjacent-day:not([disabled]) { | |||
There was a problem hiding this comment.
Suggested change
| :host .calendar-day.calendar-day-adjacent-day:not([disabled]) { | |
| :host .calendar-day.calendar-day-adjacent-day { |
| border: 1px solid current-color(base); | ||
|
|
||
| background: current-color(base); | ||
| } | ||
|
|
||
| :host .calendar-day.calendar-day-adjacent-day:not([disabled]) { |
There was a problem hiding this comment.
Suggested change
| :host .calendar-day.calendar-day-adjacent-day:not([disabled]) { | |
| :host .calendar-day.calendar-day-adjacent-day { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: Internal
What is the new behavior?
Adds a new property to datetime,
showAdjacentDays, that when true will show the last days of the previous month and the first days of the next month. This will just occupy empty "cells" at the beginning of the month "table" and add rows to the table until a maximum of 6 rows are displayed.Changes
showAdjacentDaysproperty to datetime componentDoes this introduce a breaking change?
Other information
Preview