Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(toggle): add helperText and errorText properties #30161

Merged
merged 15 commits into from
Mar 10, 2025

Conversation

brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Jan 28, 2025

Issue number: N/A


What is the current behavior?

Toggle does not support helper and error text.

What is the new behavior?

Adds support for helper and error text, similar to input and textarea.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Copy link

vercel bot commented Jan 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 10, 2025 10:33pm

@github-actions github-actions bot added package: core @ionic/core package package: angular @ionic/angular package package: vue @ionic/vue package labels Jan 28, 2025
@brandyscarney brandyscarney changed the base branch from main to feature-8.5 January 28, 2025 23:22
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The supporting text being read twice is the main issue.

The rest are just questions that were asked over in the checkbox PR that can be applied here.

Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

// ----------------------------------------------------------------

.toggle-bottom {
@include padding(4px, null, null, null);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be on the native partial and on Ionic theme use the proper space token.

@brandyscarney brandyscarney merged commit 94ca2e5 into feature-8.5 Mar 10, 2025
48 checks passed
@brandyscarney brandyscarney deleted the ROU-11552 branch March 10, 2025 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: angular @ionic/angular package package: core @ionic/core package package: vue @ionic/vue package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants