Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): respect all allowed origins on modern WebViewCompat JS injection #7571

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

martin-braun
Copy link

@martin-braun martin-braun commented Jul 19, 2024

Fixes #7454

I applied the fix from @rfe-css at #7454, but I figured my device would skip this, so please someone can verify this before merge.

@michaelkhabarov
Copy link

Is there a chance this to be merged?

@martin-braun
Copy link
Author

martin-braun commented Sep 21, 2024

Since I added this fix, I had the chance to test it on a device that was affected by the bug and this patch works flawlessly.

@michaelkhabarov No idea at this point. I got silenced at #7570, too, but it's an entirely different issue that was confused with the existing one.

It makes me feel discouraged for contributing any further.

@marcusdiy
Copy link

Soooo, can we merge this or what?

@martin-braun
Copy link
Author

martin-braun commented Feb 26, 2025

Soooo, can we merge this or what?

It was free of conflicts and ready to merge for months after I created the PR, but the maintainers did not look into this. Now, we have a new major Capacitor version. So the issue is still present? I'm just using my patched fork to make things work for myself since then.

In my opinion the PR wasn't handled properly, but I

  • Allow edits by maintainers

so they are free to resolve the conflicts and merge this into the new version if the issue still exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Capacitor on Android detected as web platform after redirecting with allowNavigation
3 participants