Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bill line charge rate and quantity #487

Merged
merged 7 commits into from
Mar 10, 2025

Conversation

samlown
Copy link
Collaborator

@samlown samlown commented Mar 6, 2025

  • Support in bill lines for charges with a Rate and optional Quantity for special types of tariffs to apply to the price.

Pre-Review Checklist

  • I have performed a self-review of my code.
  • I have added thorough tests with at least 90% code coverage.
  • I've modified or created example GOBL documents to show my changes in use, if appropriate.
  • When adding or modifying a tax regime or addon, I've added links to the source of the changes, either structured or in the comments.
  • I've run go generate . to ensure that the Schemas and Regime data are up to date.
  • All linter warnings have been reviewed and fixed.
  • I've been obsessive with pointer nil checks to avoid panics.
  • The CHANGELOG.md has been updated with an overview of my changes.
  • Requested a review from @samlown.

Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.38%. Comparing base (5e7b060) to head (5f65391).

Additional details and impacted files
@@                  Coverage Diff                   @@
##           fix-rounding-lines     #487      +/-   ##
======================================================
+ Coverage               87.30%   87.38%   +0.08%     
======================================================
  Files                     264      264              
  Lines                   13538    13628      +90     
======================================================
+ Hits                    11819    11909      +90     
  Misses                   1373     1373              
  Partials                  346      346              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@samlown samlown merged commit 9749985 into fix-rounding-lines Mar 10, 2025
2 checks passed
@samlown samlown deleted the add-bill-charge-rate branch March 10, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant