Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix amount inversion on credit notes #12

Merged
merged 6 commits into from
Mar 20, 2024
Merged

Fix amount inversion on credit notes #12

merged 6 commits into from
Mar 20, 2024

Conversation

cavalle
Copy link
Contributor

@cavalle cavalle commented Mar 19, 2024

@cavalle cavalle requested a review from samlown March 19, 2024 09:17
samlown
samlown approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@samlown samlown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I've also bumped with the latest GOBL Invert method.

cavalle
cavalle commented Mar 20, 2024
View reviewed changes
Copy link
Contributor Author

@cavalle cavalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the additional changes. Everything LGTM!

@samlown samlown merged commit 747bfbd into main Mar 20, 2024
2 checks passed
@samlown samlown deleted the fix-invert branch March 20, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samlown samlown samlown approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cavalle @samlown