Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using latest GOBL v0.56 with complements #55

Merged
merged 1 commit into from
Sep 8, 2023
Merged

Using latest GOBL v0.56 with complements #55

merged 1 commit into from
Sep 8, 2023

Conversation

samlown
Copy link
Contributor

@samlown samlown commented Sep 7, 2023

  • Moving gobl.Document to schema.Object

@samlown samlown requested a review from cavalle September 7, 2023 16:22
cavalle
cavalle approved these changes Sep 8, 2023
View reviewed changes
Copy link
Collaborator

@cavalle cavalle left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! There's probably room to refactor and make GOBL::Schema::Object less protagonist (specially for users of the library). I never loved having to embed and extract documents anyway. It felt like unnecessary boilerplate code.

For the moment, though, I think it's fine to go ahead just renaming Document to Schema::Object

@samlown
Copy link
Contributor Author

samlown commented Sep 8, 2023

My thoughts exactly @cavalle! I'll add a issue to reflect that. Ideally the GOBL::Envelope should be the main entry point with the insert and extract methods.

@samlown samlown merged commit 9e68c3f into main Sep 8, 2023
@samlown samlown mentioned this pull request Sep 8, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cavalle cavalle cavalle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samlown @cavalle