Skip to content

[UR] Remove unused UR_EXT_DEVICE_INFO_OPENCL_C_VERSION #19069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: sycl
Choose a base branch
from
Open

[UR] Remove unused UR_EXT_DEVICE_INFO_OPENCL_C_VERSION #19069

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions unified-runtime/source/adapters/cuda/device.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -607,9 +607,6 @@ UR_APIEXPORT ur_result_t UR_APICALL urDeviceGetInfo(ur_device_handle_t hDevice,
SS << "." << Minor;
return ReturnValue(SS.str().c_str());
}
case UR_EXT_DEVICE_INFO_OPENCL_C_VERSION: {
return ReturnValue("");
}
case UR_DEVICE_INFO_EXTENSIONS: {
std::string SupportedExtensions = "cl_khr_fp64 ";

Expand Down
3 changes: 0 additions & 3 deletions unified-runtime/source/adapters/hip/device.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,9 +493,6 @@ UR_APIEXPORT ur_result_t UR_APICALL urDeviceGetInfo(ur_device_handle_t hDevice,
#endif
return ReturnValue(S.str().c_str());
}
case UR_EXT_DEVICE_INFO_OPENCL_C_VERSION: {
return ReturnValue("");
}
case UR_DEVICE_INFO_EXTENSIONS: {
std::string SupportedExtensions = "";

Expand Down
2 changes: 0 additions & 2 deletions unified-runtime/source/adapters/level_zero/device.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,8 +514,6 @@ ur_result_t urDeviceGetInfo(
return ReturnValue(*Device->SubDeviceCreationProperty);
}
// Everything under here is not supported yet
case UR_EXT_DEVICE_INFO_OPENCL_C_VERSION:
return ReturnValue("");
case UR_DEVICE_INFO_PREFERRED_INTEROP_USER_SYNC:
return ReturnValue(static_cast<ur_bool_t>(true));
case UR_DEVICE_INFO_PRINTF_BUFFER_SIZE:
Expand Down
2 changes: 0 additions & 2 deletions unified-runtime/source/adapters/native_cpu/device.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,8 +214,6 @@ UR_APIEXPORT ur_result_t UR_APICALL urDeviceGetInfo(ur_device_handle_t hDevice,
*pPropSizeRet = 0;
}
return UR_RESULT_SUCCESS;
case UR_EXT_DEVICE_INFO_OPENCL_C_VERSION:
return ReturnValue("");
case UR_DEVICE_INFO_QUEUE_PROPERTIES:
return ReturnValue(
ur_queue_flag_t(UR_QUEUE_FLAG_OUT_OF_ORDER_EXEC_MODE_ENABLE |
Expand Down
7 changes: 0 additions & 7 deletions unified-runtime/source/adapters/opencl/device.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1183,13 +1183,6 @@ UR_APIEXPORT ur_result_t UR_APICALL urDeviceGetInfo(ur_device_handle_t hDevice,

return UR_RESULT_SUCCESS;
}
case UR_EXT_DEVICE_INFO_OPENCL_C_VERSION: {
CL_RETURN_ON_FAILURE(clGetDeviceInfo(hDevice->CLDevice,
CL_DEVICE_OPENCL_C_VERSION, propSize,
pPropValue, pPropSizeRet));

return UR_RESULT_SUCCESS;
}
case UR_DEVICE_INFO_BUILT_IN_KERNELS: {
CL_RETURN_ON_FAILURE(clGetDeviceInfo(hDevice->CLDevice,
CL_DEVICE_BUILT_IN_KERNELS, propSize,
Expand Down
6 changes: 1 addition & 5 deletions unified-runtime/source/ur/ur.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,11 +81,7 @@ template <> uint32_t inline ur_cast(uint64_t Value) {
return CastedValue;
}

// TODO: promote all of the below extensions to the Unified Runtime
// and get rid of these ZER_EXT constants.
const ur_device_info_t UR_EXT_DEVICE_INFO_OPENCL_C_VERSION =
(ur_device_info_t)0x103D;

// TODO: Promote the below extensions to the Unified Runtime?
const ur_command_t UR_EXT_COMMAND_TYPE_USER =
(ur_command_t)((uint32_t)UR_COMMAND_FORCE_UINT32 - 1);

Expand Down