Skip to content

[BINDLESS][L0][E2E] set SAMPLED_IMAGE_FETCH_1D_SUPPORT true #19019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2025

Conversation

JackAKirk
Copy link
Contributor

Level zero is the only backend that supports 1D fetch. However it was marked as unsupported. This PR fixes that and adds corresponding tests.

As with other fetch cases, O0 builds fail on windows for L0 using fetch 1D (see #18919).

Add corresponding tests

Signed-off-by: JackAKirk <[email protected]>
@JackAKirk JackAKirk marked this pull request as ready for review June 18, 2025 10:10
@JackAKirk JackAKirk requested review from a team as code owners June 18, 2025 10:10
@JackAKirk
Copy link
Contributor Author

@intel/llvm-gatekeepers this is ready to merge.

Thanks

@kbenzie
Copy link
Contributor

kbenzie commented Jun 20, 2025

Merging is blocked pending review from @intel/unified-runtime-reviewers-level-zero

@JackAKirk
Copy link
Contributor Author

Merging is blocked pending review from @intel/unified-runtime-reviewers-level-zero

Thanks! missed that!

@DBDuncan
Copy link
Contributor

I am leaning toward that fetch_1D.hpp should be in the helper folder as the file itself does not run and instead is included in other test files. What do you think?

@JackAKirk
Copy link
Contributor Author

I am leaning toward that fetch_1D.hpp should be in the helper folder as the file itself does not run and instead is included in other test files. What do you think?

I don't have a strong feeling either way, although I think if I put headers in a helper folder then I should create a new helper folder within the sampled_fetch folder rather than just using a single help folder in the source bindless images directory. Otherwise it partially defeats the point of having subdirectories at all.

@JackAKirk
Copy link
Contributor Author

@intel/llvm-gatekeepers this is ready to merge.

Thanks

@sommerlukas sommerlukas merged commit 4fea3ad into intel:sycl Jun 24, 2025
45 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants