-
Notifications
You must be signed in to change notification settings - Fork 788
[BINDLESS][L0][E2E] set SAMPLED_IMAGE_FETCH_1D_SUPPORT true #19019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BINDLESS][L0][E2E] set SAMPLED_IMAGE_FETCH_1D_SUPPORT true #19019
Conversation
Add corresponding tests Signed-off-by: JackAKirk <[email protected]>
Signed-off-by: JackAKirk <[email protected]>
@intel/llvm-gatekeepers this is ready to merge. Thanks |
Merging is blocked pending review from @intel/unified-runtime-reviewers-level-zero |
Thanks! missed that! |
I am leaning toward that |
I don't have a strong feeling either way, although I think if I put headers in a helper folder then I should create a new helper folder within the sampled_fetch folder rather than just using a single help folder in the source bindless images directory. Otherwise it partially defeats the point of having subdirectories at all. |
@intel/llvm-gatekeepers this is ready to merge. Thanks |
Level zero is the only backend that supports 1D fetch. However it was marked as unsupported. This PR fixes that and adds corresponding tests.
As with other fetch cases, O0 builds fail on windows for L0 using fetch 1D (see #18919).