[SYCL][Doc] Add new device descriptors to sycl_ext_intel_device_info extension #17386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pennycook
reviewed
Mar 11, 2025
|
|
||
| | Device Descriptors | Return Type | Description | | ||
| | ------------------ | ----------- | ----------- | | ||
| | `ext::intel::info::device::current_clock_throttle_reasons` | `std::vector<ext::intel::throttle_reason>` | Returns the set of throttle reasons describing why the frequency is being limited by the hardware. Returns empty set if frequency is not throttled. | |
There was a problem hiding this comment.
As written, this descriptor is GPU-specific: the introduction talks about the "GPU clock" and the descriptions of the throttle reasons say "GPU". The other queries that are GPU-specific (e.g. number of EUs) are all prefixed with gpu_.
I think we should either:
- Rename this to
gpu_current_throttle_reasons; or - Remove "GPU" from the introduction and description.
I have a slight preference for 2, because the throttle reasons are already guarded by an aspect. If we never implement this extension on another device (e.g., CPU), we just won't enable the aspect anywhere except GPUs. But removing "GPU" from the description gives us the option to try and implement it on other devices.
There was a problem hiding this comment.
Thank you, sounds reasonable, I have applied option 2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.