Feat: implement aggregator `slave` signer registration mode #2351

jpraynaud · 2025-03-05T17:11:05Z

Content

This PR includes the implementation of a slave signer registration mode in the aggregator.

Pre-submit checklist

Branch
- Tests are provided (if possible)
- Crates versions are updated (if relevant)
- CHANGELOG file is updated (if relevant)
- Commit sequence broadly makes sense
- Key commits have useful messages
PR
- No clippy warnings in the CI
- Self-reviewed the diff
- Useful pull request description
- Reviewer requested

Issue(s)

Closes #2334
Closes #2335

mithril-aggregator/src/dependency_injection/builder/protocol/certificates.rs

mithril-aggregator/src/dependency_injection/builder/support/upkeep.rs

github-actions · 2025-03-05T17:19:08Z

Test Results

3 files ± 0 56 suites +1 10m 32s ⏱️ +3s
1 713 tests +30 1 713 ✅ +30 0 💤 ±0 0 ❌ ±0
2 105 runs +30 2 105 ✅ +30 0 💤 ±0 0 ❌ ±0

Results for commit 4c90983. ± Comparison against base commit 468de2d.

This pull request removes 23 and adds 53 tests. Note that renamed tests count towards both.

mithril-aggregator ‑ http_server::routes::epoch_routes::tests::get_epoch_settings_message_retrieves_protocol_parameters_from_epoch_service
mithril-aggregator ‑ http_server::routes::epoch_routes::tests::get_epoch_settings_message_retrieves_signing_configuration_from_epoch_service
mithril-aggregator ‑ http_server::routes::epoch_routes::tests::get_epoch_settings_message_with_cardano_transactions_enabled
mithril-aggregator ‑ http_server::routes::epoch_routes::tests::get_epoch_settings_message_with_cardano_transactions_not_enabled
mithril-aggregator ‑ message_adapters::from_register_signature::tests::test_simple_message
mithril-aggregator ‑ message_adapters::from_register_signer::tests::test_simple_message
mithril-aggregator ‑ message_adapters::to_cardano_transactions_proof_message::tests::test_simple_message
mithril-aggregator ‑ runtime::state_machine::tests::critical_error
mithril-aggregator ‑ runtime::state_machine::tests::idle_check_certificate_chain_is_not_valid
mithril-aggregator ‑ runtime::state_machine::tests::idle_check_certificate_chain_is_valid
…

mithril-aggregator ‑ configuration::test::is_slave_aggregator_returns_false_when_in_master_mode
mithril-aggregator ‑ configuration::test::is_slave_aggregator_returns_true_when_in_slave_mode
mithril-aggregator ‑ message_adapters::from_epoch_settings::tests::try_adapt_epoch_settings_message_to_entity
mithril-aggregator ‑ message_adapters::from_register_signature::tests::try_adapt_single_signatures_message_to_entity
mithril-aggregator ‑ message_adapters::from_register_signer::tests::try_adapt_signer_registration_message_to_entity
mithril-aggregator ‑ message_adapters::to_cardano_transactions_proof_message::tests::try_adapt_cardano_transaction_proof_to_message
mithril-aggregator ‑ runtime::state_machine::tests::master::critical_error
mithril-aggregator ‑ runtime::state_machine::tests::master::idle_check_certificate_chain_is_not_valid
mithril-aggregator ‑ runtime::state_machine::tests::master::idle_check_certificate_chain_is_valid
mithril-aggregator ‑ runtime::state_machine::tests::master::ready_certificate_does_not_exist_for_time_point
…

♻️ This comment has been updated with latest results.

Alenar

LGTM

mithril-aggregator/src/services/aggregator_client.rs

mithril-aggregator/src/runtime/runner.rs

mithril-aggregator/src/dependency_injection/builder/mod.rs

mithril-aggregator/src/commands/serve_command.rs

mithril-aggregator/src/dependency_injection/builder/enablers/misc.rs

mithril-aggregator/src/signer_registration/slave.rs

mithril-aggregator/tests/create_certificate_slave.rs

dlachaume

LGTM 👍

mithril-aggregator/src/runtime/runner.rs

mithril-common/src/entities/epoch.rs

mithril-aggregator/tests/create_certificate_slave.rs

sfauvel

LGTM
Some remarks to improve readability

mithril-aggregator/src/commands/serve_command.rs

mithril-aggregator/src/dependency_injection/builder/mod.rs

mithril-aggregator/src/message_adapters/from_epoch_settings.rs

mithril-aggregator/src/runtime/runner.rs

mithril-aggregator/src/runtime/state_machine.rs

mithril-aggregator/src/signer_registration/master.rs

mithril-aggregator/src/signer_registration/slave.rs

…regator If this optional parameter is set, the aggregator will run in slave mode for the signer registrations.

…ion in 'MithrilSignerRegisterer'

Better handling of 'SignerRegisterer', 'SignerRegistrationRoundOpener' and 'SignerRegistrationVerifier'.

…rers

In slave mode, the aggregator will synchronize signer registrations from master aggregator.

To expose the '/epoch-settings' route.

…gistration

* mithril-aggregator from `0.7.10` to `0.7.11` * mithril-common from `0.5.9` to `0.5.10` * mithril-signer from `0.2.232` to `0.2.233`

jpraynaud self-assigned this Mar 5, 2025

github-advanced-security bot found potential problems Mar 5, 2025

View reviewed changes

mithril-aggregator/src/dependency_injection/builder/protocol/certificates.rs Fixed Show fixed Hide fixed

mithril-aggregator/src/dependency_injection/builder/support/upkeep.rs Fixed Show fixed Hide fixed

jpraynaud temporarily deployed to testing-preview March 5, 2025 17:26 — with GitHub Actions Inactive

jpraynaud force-pushed the jpraynaud/2334-aggregator-slave-registration-mode branch from 335da84 to b967279 Compare March 5, 2025 17:49

jpraynaud temporarily deployed to testing-preview March 5, 2025 18:01 — with GitHub Actions Inactive

jpraynaud force-pushed the jpraynaud/2334-aggregator-slave-registration-mode branch from b967279 to 11f1df6 Compare March 6, 2025 14:14

jpraynaud had a problem deploying to testing-preview March 6, 2025 14:23 — with GitHub Actions Error

jpraynaud force-pushed the jpraynaud/2334-aggregator-slave-registration-mode branch from 11f1df6 to 866de28 Compare March 6, 2025 14:23

jpraynaud marked this pull request as ready for review March 6, 2025 14:26

jpraynaud temporarily deployed to testing-preview March 6, 2025 14:32 — with GitHub Actions Inactive

jpraynaud requested review from Alenar, sfauvel and dlachaume March 6, 2025 14:35

Alenar approved these changes Mar 6, 2025

View reviewed changes

jpraynaud temporarily deployed to testing-preview March 6, 2025 18:07 — with GitHub Actions Inactive

Alenar reviewed Mar 6, 2025

View reviewed changes

mithril-aggregator/tests/create_certificate_slave.rs Outdated Show resolved Hide resolved

dlachaume approved these changes Mar 7, 2025

View reviewed changes

mithril-aggregator/src/runtime/runner.rs Outdated Show resolved Hide resolved

mithril-common/src/entities/epoch.rs Show resolved Hide resolved

mithril-aggregator/tests/create_certificate_slave.rs Outdated Show resolved Hide resolved

sfauvel approved these changes Mar 7, 2025

View reviewed changes

jpraynaud added 11 commits March 7, 2025 18:03

feat: add a master aggregator endpoint configuration parameter of agg…

0c1a6ae

…regator If this optional parameter is set, the aggregator will run in slave mode for the signer registrations.

feat: add 'SignerRegistrationVerifier' trait

1b5b6a6

refactor: use 'SignerRegistrationVerifier' for registration verificat…

f6edf2d

…ion in 'MithrilSignerRegisterer'

refactor: dependency building of aggregator

c8730c6

Better handling of 'SignerRegisterer', 'SignerRegistrationRoundOpener' and 'SignerRegistrationVerifier'.

feat: add master aggregator epoch settings in aggregator

818c4df

feat: add an aggregator client to aggregator

e310a09

feat: implement slave signer registerer in aggregator

a5b8334

refactor: dependency injection for signer slave/master signer registe…

d2ceafe

…rers

feat: update runners to support slave aggregator mode

24bd3da

In slave mode, the aggregator will synchronize signer registrations from master aggregator.

feat: update state machine to support slave aggregator mode

67155b2

refactor: epoch settings message moved to message service

e5cbe3e

jpraynaud added 12 commits March 7, 2025 18:03

feat: extend integration test tooling in aggregator

60d94f0

To expose the '/epoch-settings' route.

feat: implement a slave aggregator integration test

d1404dc

refactor: create 'signer_registration' module in aggregator

dff1d3a

refactor: enhance namings in 'signer_registration' module of aggregator

ae93c79

refactor: better readability of slave aggregator integration test

33273d9

fix: apply review comments

572e86f

refactor: enhanced signer synchronizer trait in aggregator

abba587

refactor: enhance readability of tests for master and slave signer re…

55343aa

…gistration

chore: apply review comments

4b12098

refactor: move 'signer_registration' module to services

2f78b11

docs: update CHANGELOG

56aeff2

chore: upgrade crate versions

4c90983

* mithril-aggregator from `0.7.10` to `0.7.11` * mithril-common from `0.5.9` to `0.5.10` * mithril-signer from `0.2.232` to `0.2.233`

jpraynaud force-pushed the jpraynaud/2334-aggregator-slave-registration-mode branch from 802e171 to 4c90983 Compare March 7, 2025 17:05

jpraynaud temporarily deployed to testing-preview March 7, 2025 17:13 — with GitHub Actions Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat: implement aggregator `slave` signer registration mode #2351

Feat: implement aggregator `slave` signer registration mode #2351

jpraynaud commented Mar 5, 2025 •

edited

Loading

github-actions bot commented Mar 5, 2025 •

edited

Loading

Alenar left a comment

dlachaume left a comment

sfauvel left a comment

Feat: implement aggregator slave signer registration mode #2351

Are you sure you want to change the base?

Feat: implement aggregator slave signer registration mode #2351

Conversation

jpraynaud commented Mar 5, 2025 • edited Loading

Content

Pre-submit checklist

Issue(s)

github-actions bot commented Mar 5, 2025 • edited Loading

Test Results

Alenar left a comment

Choose a reason for hiding this comment

dlachaume left a comment

Choose a reason for hiding this comment

sfauvel left a comment

Choose a reason for hiding this comment

Feat: implement aggregator `slave` signer registration mode #2351

Feat: implement aggregator `slave` signer registration mode #2351

jpraynaud commented Mar 5, 2025 •

edited

Loading

github-actions bot commented Mar 5, 2025 •

edited

Loading