-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kafka): Set and send SASL extensions #2832
Conversation
Looks like there's a bug. But I'm having a hard time deciphering the test code.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test failed because of the upgraded Sarama package (I haven't investigated the exact problem). For simplicity, I suggest keeping the previous Sarama library version.
I've fixed the PR. The Sarama version is set to 1.40.1, which is the last where the test works. I'm still investigating the exact problem causing the test fails. @gunnaraasen, is there a specific reason why there should be Sarama version 1.41.3 you previously set? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 🚀
Following our discussion here: https://influxdata.slack.com/archives/C5BSZ026L/p1725387374078259, it is okay to use Sarama v1.40.1.
Required checklist
/etc
folder andNewDemoConfig
methods) (influxdb and plutonium)openapi swagger.yml updated (if modified API) - link openapi PRDescription
Allows SASL extensions to be set via config. Also updates the
samara
dependency to use the new IBM source.