Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): upgrade Go to 1.20.10 #2783

Merged
merged 1 commit into from
Oct 12, 2023
Merged

chore(build): upgrade Go to 1.20.10 #2783

merged 1 commit into from
Oct 12, 2023

Conversation

alespour
Copy link
Contributor

@alespour alespour marked this pull request as ready for review October 12, 2023 12:37
@alespour alespour requested a review from tomklapka October 12, 2023 12:37
Copy link
Contributor

@jdstrand jdstrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but can you also address https://github.com/influxdata/kapacitor/security/dependabot/29 for golang.org/x/net which is for the same issue?

$ go mod why -m golang.org/x/net
# golang.org/x/net
github.com/influxdata/kapacitor/services/azure
github.com/prometheus/common/config
golang.org/x/net/http2

@jdstrand
Copy link
Contributor

Approving, but can you also address HTTP/2 rapid reset can cause excessive work in net/http for golang.org/x/net which is for the same issue?

$ go mod why -m golang.org/x/net
# golang.org/x/net
github.com/influxdata/kapacitor/services/azure
github.com/prometheus/common/config
golang.org/x/net/http2

I actually approved https://github.com/influxdata/kapacitor/security/dependabot/29 and merged it.

@alespour alespour merged commit 957d384 into master Oct 12, 2023
@alespour alespour deleted the chore/go1.20.10 branch October 12, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants