Update build.py to support arm64 #2289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently arm64 aka aarch64 results in armhf binaries. Not ARM64 binaries. Modern arm chips (like those in TV boxes) does not support armhf instruction set. exec format error. The first change will detect aarch64 and set arch to arm64, which is supported. Cleaned up code around line 540 to store arch in fullarch for later use in if statement below that sets GOARM. Line 543 would overwrite the value tested in the if statement in 546 and down. According to this: https://github.com/golang/go/wiki/GoArm GOARM should not be used for arm64
|
Same style patch applied to Chronograf. |
|
thanks @povlhp -- appreciate your contribution. |
docmerlin
approved these changes
Apr 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently arm64 aka aarch64 results in armhf binaries. Not ARM64 binaries.
Modern arm chips (like those in TV boxes) does not support armhf instruction set. exec format error.
The first change will detect aarch64 and set arch to arm64, which is supported.
Cleaned up code around line 540 to store arch in fullarch for later use in if statement below that sets GOARM. Line 543 would overwrite the value tested in the if statement in 546 and down.
According to this: https://github.com/golang/go/wiki/GoArm GOARM should not be used for arm64
Required for all non-trivial PRs