Add templating for MQTT topics #2202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the ability to use templates when specifying the MQTT
topic. This is much more useful than static topics since you
can create topics like this:
switches/{{ index .Tags "agent_host" }}/ports/{{ index .Tags "port_num" }}
fhriley
force-pushed
the
mqtt_topic_template
branch
from
69d6a6e to
dc34e23
Compare
|
Is anyone looking at these? |
|
@nathanielc @aanthony1243 Can someone look at this? We are using this in production, but we prefer not to have to maintain a custom build of kapacitor. The static topics that kapacitor supports without this change are essentially useless. |
nathanielc
suggested changes
Aug 7, 2019
…template during handler construction.
nathanielc
approved these changes
Aug 8, 2019
|
@fhriley LGTM, can you fix the conflicts and then I can merge. |
|
Merge conflict resolved. |
nathanielc
reviewed
Aug 8, 2019
There was a problem hiding this comment.
Thanks. I completely forgot but could you add a test for this? Should be as simple as copy pasting this test case here and then using a template as the topic and validating it works.
|
Test added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to use templates when specifying the MQTT
topic. This is much more useful than static topics since you
can create topics like this:
switches/{{ index .Tags "agent_host" }}/ports/{{ index .Tags "port_num" }}
Required for all non-trivial PRs