Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed docs-apps #163

Merged
merged 7 commits into from
Feb 27, 2025
Merged

Renamed docs-apps #163

merged 7 commits into from
Feb 27, 2025

Conversation

ijlee2
Copy link
Owner

@ijlee2 ijlee2 commented Feb 27, 2025

Background

In the next pull request, I'll introduce an Embroider app built with Vite (a so-called "v2 app") for documentation. Here, I renamed my-app and my-app-with-ember-css-modules to clarify that these are considered "v1 apps."

@ijlee2 ijlee2 added enhance: documentation Issue asks for better documentation (e.g. README, code, tests) enhance: dependency Issue asks for a new or updated dependency labels Feb 27, 2025
Copy link

netlify bot commented Feb 27, 2025

Deploy Preview for embroider-css-modules ready!

Name Link
🔨 Latest commit 1f299e4
🔍 Latest deploy log https://app.netlify.com/sites/embroider-css-modules/deploys/67c065f21284ae0008d38f7d
😎 Deploy Preview https://deploy-preview-163--embroider-css-modules.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ijlee2 ijlee2 marked this pull request as ready for review February 27, 2025 13:19
@ijlee2 ijlee2 merged commit 3cdbf54 into main Feb 27, 2025
41 checks passed
@ijlee2 ijlee2 deleted the rename-apps branch February 27, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhance: dependency Issue asks for a new or updated dependency enhance: documentation Issue asks for better documentation (e.g. README, code, tests)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant