Created a Vite app for documentation #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijlee2
added
the
enhance: documentation
✅ Deploy Preview for embroider-css-modules ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ijlee2
force-pushed
the
document-vite-app
branch
from
2860032 to
86090da
Compare
ijlee2
force-pushed
the
document-vite-app
branch
from
86090da to
2065825
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
In March 2024, I had created
embroider-css-modules-vite-appto show thatembroider-css-modulesalready works on a Vite app (a "v2 app"), at a time when the blueprint for v2 apps was in draft. I hadn't moved the app to this repo, because the associated dependencies from Embroider would be unstable for a while.Now that some time has passed, I decided to create an app from the latest blueprint. This will help us regularly check through CI that
embroider-css-modulesworks on v2 apps.