Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve parsed tensor coverage #25

Merged
merged 2 commits into from
Mar 3, 2025
Merged

Improve parsed tensor coverage #25

merged 2 commits into from
Mar 3, 2025

Conversation

dschwen
Copy link
Member

@dschwen dschwen commented Feb 26, 2025

Refs #6

@dschwen
Copy link
Member Author

dschwen commented Feb 26, 2025

The unit tests are the first tests that are actually running on a cuda device. And no I have added libtorch_devices = 'cpu cuda' to the system tests as well. All this passes locally, but the apptainer used for running the tests still has the nvrtc: error: failed to open libnvrtc-builtins.so.12.1 (which could be easily fixed with a simple symlink, @loganharbour ...).

@idaholab idaholab deleted a comment from moosebuild Feb 26, 2025
@moosebuild
Copy link

moosebuild commented Feb 27, 2025

Job Documentation, step Sync to remote on 7efe8b4 wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link

Job Coverage, step Generate coverage on 7efe8b4 wanted to post the following:

Coverage

63afa3 #25 7efe8b
Total Total +/- New
Rate 55.55% 61.21% +5.66% 88.89%
Hits 1567 1739 +172 24
Misses 1254 1102 -152 3

Diff coverage report

Full coverage report

Warnings

  • New new line coverage rate 88.89% is less than the suggested 90.0%

This comment will be updated on new commits.

@dschwen dschwen merged commit e556d5e into devel Mar 3, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants