GA features update - Having multi-objective optimization (NSGA-II ) #2326
Conversation
…tests. Most of conflicts are resolved.
…enablingMinMaxList
|
Job Test slurm bitterroot on 8943fef : invalidated by @joshua-cogliati-inl failed in build_raven remove directories. |
|
Job Test slurm bitterroot on 1b1d6e7 : invalidated by @joshua-cogliati-inl failed in build_raven remove directories. |
1 similar comment
|
Job Test slurm bitterroot on 1b1d6e7 : invalidated by @joshua-cogliati-inl failed in build_raven remove directories. |
|
Job Mingw Test on dfaf577 : invalidated by @joshua-cogliati-inl failed in fetch |
|
Job Test qsubs sawtooth legacy on fb4c93d : invalidated by @joshua-cogliati-inl failed in fetch |
|
Job Test qsubs sawtooth on fb4c93d : invalidated by @joshua-cogliati-inl failed in fetch |
|
Job Test slurm bitterroot on fb4c93d : invalidated by @joshua-cogliati-inl failed in build_raven remove directories. |
1 similar comment
|
Job Test slurm bitterroot on fb4c93d : invalidated by @joshua-cogliati-inl failed in build_raven remove directories. |
|
@Jimmy-INL , @wangcj05, FYI, the tests passed for the current version of NSGA-II. |
Jimmy-INL
dismissed
their stale review
Josh has addressed most of my requests. The rest might be followups in future PRs.
|
@joshua-cogliati-inl @Jimmy-INL @wangcj05 can anybody from INL make sure that the GA works with Raven Running Raven? I am getting crashes also for a single objective optimization. I opened few issues on this in the past but it seems that this MR does not fix them (since there are no tests associated with them) (No need to fix it in this PR but maybe a "priority_critical" issue in case it does not work on your side would be nice to capture this) |
|
GA only on the inner?
Best,
Mohammad G. Abdo, Ph.D.
Modeling and Simulation Scientist | Digital Reactor Technology and Development (C160)
Reactor Systems Design and Analysis | NS&T
***@***.******@***.***> | REC EROB IF-654 3EL103 | Phone: 208-526-4640
Idaho National Laboratory | 2525 Fremont Ave. | Idaho Falls, ID | 83415
[6GC4jc7QCCEAAAAASUVORK5CYII=]<https://www.linkedin.com/in/mohammad-abdo-a7625082/>. [PXly9OZ1PK9LcRv4PSG3pAb9jevQAAAAASUVORK5CYII=] <https://www.researchgate.net/profile/Mohammad_Abdo/research> [RPr5ytnPx9Cc691m9I+4T+nIo7v4HxgxndxMwKP8AAAAASUVORK5CYII=] <https://github.com/Jimmy-INL>
…___________________________________
[wYtJH347IiIiAYVYS1skEvgxC4KpkYRTFRBbsT51peEIp5j0ExRuvWouzr1J+za4DYirM+SlQmTZXUTsvjtVtouILWngWSxC+xJbAP86Fg5oVmy2ERH1w38A8nnHfeT8na8AAAAASUVORK5CYII=]
From: Andrea Alfonsi - NuCube ***@***.***>
Date: Friday, March 7, 2025 at 4:21 PM
To: idaholab/raven ***@***.***>
Cc: Mohammad Gamal M Mostafa Abdo ***@***.***>, Mention ***@***.***>
Subject: Re: [idaholab/raven] GA features update - Having multi-objective optimization (NSGA-II ) (PR #2326)
@joshua-cogliati-inl<https://github.com/joshua-cogliati-inl> @Jimmy-INL<https://github.com/Jimmy-INL> @wangcj05<https://github.com/wangcj05> can anybody from INL make sure that the GA works with Raven Running Raven? I am getting crashes also for a single objective optimization.
(No need to fix it in this PR but maybe a "priority_critical" issue in case it does not work on your side would be nice to capture this)
—
Reply to this email directly, view it on GitHub<#2326 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AMP5ECUI7RWTBQB24C72T432TISWZAVCNFSM6AAAAABIGDMN52VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMBXGY4TENJUHA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
[Image removed by sender. alfoa]alfoa left a comment (idaholab/raven#2326)<#2326 (comment)>
@joshua-cogliati-inl<https://github.com/joshua-cogliati-inl> @Jimmy-INL<https://github.com/Jimmy-INL> @wangcj05<https://github.com/wangcj05> can anybody from INL make sure that the GA works with Raven Running Raven? I am getting crashes also for a single objective optimization.
(No need to fix it in this PR but maybe a "priority_critical" issue in case it does not work on your side would be nice to capture this)
—
Reply to this email directly, view it on GitHub<#2326 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AMP5ECUI7RWTBQB24C72T432TISWZAVCNFSM6AAAAABIGDMN52VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMBXGY4TENJUHA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
On both (inner and outer) |
@Jimmy-INL I attach 2 example inputs that show the structure of what I am talking about (2 GA, 1 outer, 1 inner) |
There was a problem hiding this comment.
@joshua-cogliati-inl Could you try to clean up this PR based on my comments. Right now, the web view is very slow. Once you have done that, please let me know, I will continue my review.
| minimalGeneticAlgorithmMultiObjective = r""" | ||
| \hspace{24pt} | ||
| Genetic Algorithm Example: | ||
| \begin{lstlisting}[style=XML] | ||
| <Optimizers> | ||
| <GeneticAlgorithm name="GAopt"> | ||
| <samplerInit> | ||
| <limit>15</limit> | ||
| <initialSeed>42</initialSeed> | ||
| <writeSteps>every</writeSteps> | ||
| <type>min,min</type> | ||
| </samplerInit> |
There was a problem hiding this comment.
It seems this example is repeating the example above it.
| @@ -11122,7 +11122,7 @@ \subsubsection{DMDBase} | |||
| performed. | |||
| \default{0} | |||
|
|
|||
| \item \xmlNode{normalize\_y}: \xmlDesc{[True, Yes, 1, False, No, 0, t, y, 1, f, n, 0]}, | |||
| \item \xmlNode{normalize\_y}: \xmlDesc{[True, Yes, 1, False, No, 0, t, y, 1, f, n, 0]}, | |||
There was a problem hiding this comment.
I do not see any obvious changes except added extra space at the end of the line. Please try to clean the end line spaces, and see if there is any changes that you want to change. It seems to me you do not need to change this file "internalRom.tex" for this PR.
There was a problem hiding this comment.
I removed all trailing whitespace in internalRom.tex, sklRom.tex and optimizer.tex.
There was a problem hiding this comment.
If you would like the whitespace removal as a separate pull request, let me know. Thanks.
There was a problem hiding this comment.
Here is the branch with just a whitespace cleanup: https://github.com/joshua-cogliati-inl/raven/tree/whitespace_cleanup
There was a problem hiding this comment.
Fixed with the merge of #2453
Note that generateOptimizerDoc uses the Optimizers.factory.knownTypes(), so only examples with the name in there will get used.
…-ManualUpdate-DefectsFix_ReBASE_05232024
Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
Closes #2069
Closes #2386
What are the significant changes in functionality due to this change request?
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.
<internalParallel>to True.raven/tests/framework/user_guideandraven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.