-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Anomaly detection #4
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My major comments are here essentialy two and they target a more rich description of some of the methods here implemented and the internal variables being used by each class
src/dackar/anomalies/AnomalyBase.py
Outdated
def __init__(self, norm='robust'): | ||
"""Constructor | ||
""" | ||
self.print_tag = type(self).__name__ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should these variables be described?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated.
|
||
logger = logging.getLogger(__name__) | ||
|
||
DASK_CLIENT_AVAIL = False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are we supporting DASK?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the stumpy library has the option to use DASK for parallel calculation
|
||
self._mp[var] = self._compute_mp(X_, y_) | ||
|
||
self._current_idx.append(n_T-1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
camelcase?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we discussed, we will keep using python "snake case" naming conventions.
@mandd FYI, I have resolved your comments. |
Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
Develop base class for anomaly detection, develop matrix profile class and add notebooks for testing
close #6
What are the significant changes in functionality due to this change request?
Add anomaly capability
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.