Feature 'byref locals and returns' is not available in C# 6.

[greenozon]

ILSpy uses byref feature even in older C# lang versions, which does not know about it.

Proposal is to use this feature only if C#7 and higher is selected, if not - do not use byref feature

Example

Erroneous output

	Vector2[] array = new Vector2[points.Count - 1];
	for (int i = 1; i < points.Count; i++)
	{
		ref Vector2 reference = ref array[i - 1];
		reference = new Vector2(GetCoord(points[i].X), GetCoord(points[i].Y));
	}

If the output fails to re-compile, provide the compiler error message.
If the output has the wrong behavior, explain how it differs from the expected behavior.

Details

• Product in use: ILSpy version 6.1.0.5902

[dgrunwald]

And what code do you propose ILSpy should emit instead?

Note that the obvious

array[i - 1] = new Vector2(GetCoord(points[i].X), GetCoord(points[i].Y));

would be incorrect: the IL code does not call GetCoord in case of an null reference or index out of bounds exception, whereas the C# code with the direct assignment would call GetCoord prior to the array access.

[greenozon]

Looked into dnSPy, it produced following result

Vector2 as well as other types are from opensource library SharpDX

GetCoord returns float:

private float GetCoord(float coord)

[dgrunwald]

dnSpy has a bug there, we fixed that in #2050.

[dgrunwald]

Maybe we should reintroduce the #2050 bug when a language version <C# 6 is selected?
We'll emit incorrect code but at least it's compilable; and the difference rarely matters.