Enhancement fix for #42 adding manage/unmanage support for volume/snapshot #45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#42 Issue descriptions:
Driver feature manage/unmanage volume/snapshot from Truenas internal reference not yet supported
Failed tempest ci test case
https://docs.openstack.org/tempest/latest/_modules/volume/admin/test_snapshot_manage.html#SnapshotManageAdminTest
https://docs.openstack.org/tempest/latest/_modules/volume/admin/test_volume_manage.html#VolumeManageAdminTest.test_unmanage_manage_volume
Solution:
Adding driver implementation method to to support cinder manage/unmanage volume/snapshot
Changes:
iscsi.py
add functions:
manage_existing
manage_existing_snapshot
manage_existing_get_size
manage_existing_snapshot_get_size
get_manageable_volumes
get_manageable_snapshots
common.py
add function
get_volume
get_snapshot
get_all_snapshot
get_volume_from_snapshot
utils.py
add function
generate_volume_id_from_freenas_volume_name
generate_snapshot_id_from_freenas_snapshot_name
Additional notes:
https://docs.openstack.org/tempest/latest/_modules/volume/admin/test_snapshot_manage.html#SnapshotManageAdminTest test failed due to no snapshot rename implemented for now