feat(core/auth/oidc): Add support of AuthCodeOption in the token exchange during callback
#338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…change during callback Currently, it is only possible to modify the authorization URL using the `AuthCodeOptioner` interface. Since the Exchange function also supports this pattern we should also pass the registered `AuthCodeOptioner` to it. Example both my authorization and my token retrieval endpoint need some custom URL param to work. Currently only the one for th auth endpoint would be possible.
carstendietrich
commented
May 16, 2023
|
carstendietrich
deleted the
feat/oidc-support-auth-code-optioner-in-callback
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it is only possible to modify the authorization URL using the
AuthCodeOptionerinterface. Since the Exchange function also supports this pattern we should also pass the registeredAuthCodeOptionerto it.For example, both my authorization and my token retrieval endpoint need some custom URL param to work. Only the one for the auth endpoint would currently be possible.