Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewriting of uploaded workflow.cfg configurable #66

Open
sverhoeven opened this issue Jan 26, 2024 · 1 comment
Open

Rewriting of uploaded workflow.cfg configurable #66

sverhoeven opened this issue Jan 26, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@sverhoeven
Copy link
Member

sverhoeven commented Jan 26, 2024

Is your feature request related to a problem? Please describe.
Now at

async function rewriteConfig(config_body: string) {
const table = parse(dedupWorkflow(config_body), { bigint: false });
table.run_dir = JOB_OUTPUT_DIR;
table.mode = "local";
table.postprocess = true;
table.clean = true;
delete table.ncores;
delete table.batch_type;
delete table.queue;
delete table.queue_limit;
delete table.concat;
delete table.self_contained;
delete table.cns_exec;
// eslint-disable-next-line @typescript-eslint/no-explicit-any
return stringify(table as any, {
newline: "\n",
indent: 2,
integer: Number.MAX_SAFE_INTEGER,
});
}
the uploaded workflow.cfg is rewritten, removing all execution related parameters. This causes haddock3 job to use 4 cpu cores. This does not use all the cores available.

Describe the solution you'd like
It would be nice if the execution section could be overwritten somehow in a configurable way.
For example with an env var to a file like HADDOCK3_EXECUTATION_SECTION=./haddock3.exec.toml with

ncores = 16

Describe alternatives you've considered

  1. Change code to adapt to instance (local dev vs production).
  2. Reconfigure bartender so it can run multiple haddock3 each with 4 cores. However I want to make a single job go as quickly as possible. Having jobs queued is ok for me.

Additional context
Using infrastructure efficiency also depends on bartender config.

@sverhoeven
Copy link
Member Author

Since #69 the HADDOCK3_NCORES env var sets the ncorers parameter.

@sverhoeven sverhoeven added the enhancement New feature or request label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant