feat(groupbar): render a border around the window and groupbar

[nnyyxxxx]

fixes #9291

example image included in #9291 , looks the exact same

hyprwm/hyprland-wiki#996

[izmyname]

Can we have those borders completely disabled, by default, please? Tbh I want to remove my eyes when I'm looking at the example image.

UPD: Also, why three new variables instead of something like expand_border_to_groupbar = 1/0 ?

[nnyyxxxx]

UPD: Also, why three new variables instead of something like expand_border_to_groupbar = 1/0 ?

why do this ? lack of customization

[izmyname]

UPD: Also, why three new variables instead of something like expand_border_to_groupbar = 1/0 ?

why do this ? lack of customization

Common sense? Why would anyone want a different border with extra options for a groupbar, when there are already settings for group windows?

[nnyyxxxx]

that's your opinion. many people would like the extra customization

[izmyname]

I'm pretty sure, they aren't, in this case.

At least, make it disabled by default, please. I'm sure many people wouldn't want to mess with three new extra variables just to fix... this.

[nnyyxxxx]

fix what?

just to fix... this.

patterns like this probably exist elsewhere in the codebase as well no need to get feisty

I'm pretty sure, they aren't, in this case.

[izmyname]

fix what?

You already fixed this, so not gonna talk about this. Thanks, btw

patterns like this probably exist elsewhere in the codebase as well no need to get feisty

what

I'm not gonna repeat myself, but to conclude: introducing three new config variables, instead of one, just to theme such a small thing as a groupbar, especially given that settings for group borders already exist - is a big brain move.

Anyway, thanks again for disabling this, by default. I don't care anymore, take care.

[nnyyxxxx]

the borders for the group and groupbar are 2 different things, no need to merge config options for both of them by adding:

expand_border_to_groupbar = 1/0

[MightyPlaza]

just coming here to add that priority already exists for extending the border

broken for a while for non floating windows and other smaller issues

[nnyyxxxx]

it looks like its merging into the groupbar though also thick asf

also doesnt even look positioned right

not a clean hack i'd say, even if its possible has many issues and crashes like you said

what if the user wants a border around the groupbar and the group? using this hack wouldn't make that possible

[MightyPlaza]

it looks like its merging into the groupbar though also thick asf

it simply moves the groupbar bounding box inside the border bounding box
I intended on polishing it up in the past (see #3197 (comment))
doe I lost interest mostly due to not using rounding myself and the code used in hyprbar / PR to do it has rounding issues

[nnyyxxxx]

it simply moves the groupbar bounding box inside the border bounding box

then this wouldnt be possible:

what if the user wants a border around the groupbar and the group? using this hack wouldn't make that possible

---

doe I lost interest mostly due to not using rounding myself and the code used in hyprbar / PR to do it had rounding issues

ic, been open for like 2 years

unrecoverable merge conflicts